feat: Initial implementation of many GCD API's using Swift Concurrency #1
Conversation
…tch constansts in libDispatch.
…wift-format and swift-lint.
… swift-format version.
…only seems to show up in linux.
…ttempt to resolve issues showing up in CI for wasm builds.
…erent way. CI will have to win on this one for now.
…th script pathing in CI.
…ux doesn't run main actor on the main thread, so the expectation was not correct. Adjusted expectations.
scottmarchant
requested review from
Austinpayne,
CrownedPhoenix,
jfilling and
NeedleInAJayStack
| @@ -0,0 +1,42 @@ | |||
| name: Pull request | |||
There was a problem hiding this comment.
Just a note, I plan to add much more extensive testing in my next PR for this repo coming the in the next week or two. I did add some basic tests just for sanity, though.
I've also tested this manually in consumption from several different repositories, and in the browser runtime in a wasm build.
It works.
| # dispatch-async |
There was a problem hiding this comment.
It would probably be a good idea to read this readme first, before reviewing the rest of the code in this PR. I explain a bit here.
|
|
||
| public var uptimeNanoseconds: UInt64 { | ||
| let beginning = uptimeBeginning | ||
| let rightNow = DispatchTime.now() |
There was a problem hiding this comment.
Oops. I wrote a bad bug here. Just found it with some new test code I'm writing. For some reason I was thinking of this function as a static variable, but it's not, it's a member variable. So we should NOT be calling DispatchTime.now() in here.
Working on a fix now.
I'll put up relevant tests in a follow on PR, as this PR is already a bit too big.
| } | ||
| } | ||
| } else { | ||
| Task { |
There was a problem hiding this comment.
Found another bug with a new test I'm writing. This works if the attribute is .concurrent. But queues are supposed to be serial by default. And this is definitely NOT serial. 😅
Will fix this as well.
Summary
Initial implementation of common GCD API's using Swift Concurrency. The goal of this implementation is to enable wasm compilation for many repositories that currently use GCD.
Note this is a critical part of larger effort to compile several open source Swift repositories to wasm
Details
DispatchAsync is a temporary experimental repository aimed at implementing missing Dispatch support in the SwiftWasm toolchain.
Currently, SwiftWasm doesn't include Dispatch.
But, SwiftWasm does support Swift Concurrency. DispatchAsync implements a number of common Dispatch API's using Swift Concurrency under the hood.
Refer to the README updates in this PR for more details.