Skip to content

Resume failed update feature #8469

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: dev
Choose a base branch
from

Conversation

Wires77
Copy link
Member

@Wires77 Wires77 commented Feb 13, 2025

Description of the problem being solved:

Occasionally, when downloading large updates for PoB, some files would fail. This would cause the entire update process to have to start over. This PR identifies files it had previously tried to download and failed that still exist in the Update folder. If they match what was about to be downloaded, we don't have to download it again. This means eventually retrying enough times might result in a successful download.

Steps taken to verify a working solution:

  • Update from a super old version, downloading almost every file
  • Observe some files failing and the download failing
  • On the next attempt, observe files being skipped that were successfully downloaded

After screenshot:

image

@Wires77 Wires77 added the enhancement New feature, calculation, or mod label Feb 13, 2025
@Wires77 Wires77 changed the title Resume failed download Resume failed update feature Feb 13, 2025
@Wires77
Copy link
Member Author

Wires77 commented Feb 13, 2025

Interestingly, some failures aren't happening on download, but on files in general, even if they already exist:
image

Not sure what's happening in Lua at that time, but that's still going to cause the update to fail even if all the files are downloaded

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature, calculation, or mod
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant