GitHub Action to find typos and lint Python code #493
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cclauss
commented
Feb 2, 2025
| @@ -127,7 +127,7 @@ bool AudioControlCS42448::inputLevelInteger(int32_t n) | |||
| return write(CS42448_DAC_Channel_Invert, data, 7); | |||
| } | |||
|
|
|||
| bool AudioControlCS42448::inputLevelInteger(int chnnel, int32_t n) | |||
| bool AudioControlCS42448::inputLevelInteger(int channel, int32_t n) | |||
There was a problem hiding this comment.
Code change! Careful review, please.
| @@ -66,7 +66,7 @@ class AudioControlCS42448 : public AudioControl | |||
| bool volumeInteger(uint32_t n); | |||
| bool volumeInteger(int channel, uint32_t n); | |||
| bool inputLevelInteger(int32_t n); | |||
| bool inputLevelInteger(int chnnel, int32_t n); | |||
| bool inputLevelInteger(int channel, int32_t n); | |||
There was a problem hiding this comment.
Code change! Careful review, please.
| if (!notifiction.fixed) { | ||
| window.clearTimeout(notifiction.timeoutid); | ||
| notifiction.close(); | ||
| var notification = currentNotifications[i]; |
There was a problem hiding this comment.
Code change! Careful review, please.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Test results: https://github.com/cclauss/Audio/actions