Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added PHP 5.6 and HHVM to travis.yml #19

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Nyholm
Copy link

@Nyholm Nyholm commented Jul 11, 2014

I also want to make sure it works with different versions of Symfony2

allow_failures:
- php: 5.5
allow_failures:
- env: SYMFONY_VERSION=dev-master
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe you should add hhvm to the allow failures block :)

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why? The tests passes on HHVM... We want to keep it that way, right?

@mmoreram
Copy link
Contributor

yes, but we have to consider also new features, with new possible dependencies. And we cannot ensure right now than new features will be compatible.

So, imho, we should ensure 100% than new features will be compatible until 5.6

@Nyholm
Copy link
Author

Nyholm commented Jul 12, 2014

Let's worry about new features and possible new dependencies in the future... If we (for some reason) need an dependency that is not supported in HHVM, lets add allow_failures: hhvm at that time then.

@mmoreram
Copy link
Contributor

And how do you want to ensure the BCBreak? I mean, are you defending that some project are using right now this bundle with HHVM, and someday maybe is not ready for that? Is it right for you?

@Nyholm
Copy link
Author

Nyholm commented Jul 12, 2014

This PR removes PHP 5.5 from allow_failures. Are you saying that this bundle might add "new features, with new possible dependencies" that is supported by PHP5.4 but not PHP5.5? Sure, HHVM is not 100% compatible with PHP at the time of writing. But each week the compatibility will increase... not decrease.

BCBreak? What are you talking about? If you develop a new feature that can't run on all the supported platforms, that's not a Backwards Compatibility break. If you really need that feature, make sure to write it in a way that works with HHVM. If it is impossible, just disable the feature for HHVM only.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants