-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added PHP 5.6 and HHVM to travis.yml #19
base: master
Are you sure you want to change the base?
Conversation
allow_failures: | ||
- php: 5.5 | ||
allow_failures: | ||
- env: SYMFONY_VERSION=dev-master |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe you should add hhvm to the allow failures block :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why? The tests passes on HHVM... We want to keep it that way, right?
yes, but we have to consider also new features, with new possible dependencies. And we cannot ensure right now than new features will be compatible. So, imho, we should ensure 100% than new features will be compatible until 5.6 |
Let's worry about new features and possible new dependencies in the future... If we (for some reason) need an dependency that is not supported in HHVM, lets add |
And how do you want to ensure the BCBreak? I mean, are you defending that some project are using right now this bundle with HHVM, and someday maybe is not ready for that? Is it right for you? |
This PR removes PHP 5.5 from BCBreak? What are you talking about? If you develop a new feature that can't run on all the supported platforms, that's not a Backwards Compatibility break. If you really need that feature, make sure to write it in a way that works with HHVM. If it is impossible, just disable the feature for HHVM only. |
I also want to make sure it works with different versions of Symfony2