Exponential backoff in logic call skips, frequent Ethereum height updates #400
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
EricBolten
commented
Apr 22, 2022
•
EricBolten
commented
- Rather than skipping calls forever after one failure, implement an exponential backoff scheme to allow for retries against transient Ethereum error conditions. Much like the previous version, this is in-memory only and the backoff process will reset on process restart.
- Add the ability to permanently skip calls in addition to having the backoff option.
- Add code to parse Gravity-defined error types, and use them to handle permanent skip conditions (yes, this code is pretty ugly, but functional).
- Add code to the gravity module and the orchestrator to periodically submit observed Ethereum heights, so we don't have to wait for a bridge event to let the Cosmos chain know the current Ethereum height. It chooses a height by a consensus-weighted vote on acceptable heights (e.g. equal to or lower than the observed height of each validator).
- Add a query endpoint so you can use the CLI to look up what the last observed heights are.
|
LGTM |
cbrit
approved these changes
Apr 23, 2022
EricBolten
changed the title
mvid
reviewed
May 2, 2022
| _ => None | ||
| } | ||
| } | ||
| _ => None |
There was a problem hiding this comment.
I can see what you meant about matching
mvid
approved these changes
May 2, 2022
zmanian
approved these changes
May 2, 2022
Codecov Report
@@ Coverage Diff @@
## main #400 +/- ##
==========================================
+ Coverage 28.26% 28.68% +0.42%
==========================================
Files 47 47
Lines 6401 6550 +149
==========================================
+ Hits 1809 1879 +70
- Misses 4447 4524 +77
- Partials 145 147 +2
|
mvid
approved these changes
May 4, 2022
| @@ -161,7 +161,8 @@ func eventVoteRecordTally(ctx sdk.Context, k keeper.Keeper) { | |||
| // 2. The proposed consensus heights from this process are greater than the values stored from the last time | |||
| // we observed an Ethereum event from the bridge | |||
| func updateObservedEthereumHeight(ctx sdk.Context, k keeper.Keeper) { | |||
| if ctx.BlockHeight()%10 != 0 { | |||
| // wait some minutes before checking the height votes | |||
| if ctx.BlockHeight()%50 != 0 { | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.