chore(mempool): refactor mempool into separate abci/data structure types and provide hooks for different state execution #63
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jsteenb2
force-pushed
the
chore/mempool_narwhal
branch
7 times, most recently
from
0709b06 to
f4a1f96
Compare
|
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
jsteenb2
force-pushed
the
chore/mempool_narwhal
branch
2 times, most recently
from
4727e0b to
91916c5
Compare
separation of concerns here gives the ability to reuse the abci specifics and change the underlying pool/data structure to suit the needs of the author.
this new type makes use of most of the new mempool.ABCI type, which provides a standard public interaction between the mempool and the rest of the monolith.
jsteenb2
force-pushed
the
chore/mempool_narwhal
branch
from
91916c5 to
66ac7a1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this refactor is part of an effort to establish a narwhal mempool without having to boil the ocean. We maintain the vast majority of the guarantees we make in the mempool/abci relationship, while allowing us to change out the the underlying data structure (clist/prioirity/narwhal/etc).