Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/verificar_sugestoes #80

Merged
merged 6 commits into from
Dec 13, 2023
Merged

Conversation

Lozavival
Copy link
Member

Implementa a verificação e validação de sugestões de empresas enviadas por usuários.

Closes #41

@Lozavival Lozavival requested a review from ra247362 December 13, 2023 03:48
Copy link
Member

@ra247362 ra247362 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Há alguns problemas, notadamente a falta da possiblidade de mudar o nome da empresa submetida pelo usuário e a falta de uma imagem padrão, o que vai quebrar o site se houver engano por parte do moderador. O código em si parece bom.

…uired

Add 'name' field to suggestion validation form, make all fields required and add/change tests.
@ra247362 ra247362 self-requested a review December 13, 2023 16:16
Copy link
Member

@ra247362 ra247362 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tudo certo. Aprovado!

@ra247362 ra247362 merged commit 295c7d2 into develop Dec 13, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants