Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Wallpaper color themes #175

Open
Joe-D01 opened this issue Dec 23, 2024 · 6 comments
Open

Support Wallpaper color themes #175

Joe-D01 opened this issue Dec 23, 2024 · 6 comments
Labels
enhancement New feature or request high priority

Comments

@Joe-D01
Copy link

Joe-D01 commented Dec 23, 2024

I'm on Android 15, but the theme always stays blue. Doesn't it support using wallpaper colors?

Edit: Just my opinion—please don’t be offended—but I think the previous UI looked much cleaner than the current one. For example, the notes' colors were better and covered the whole page.

@PhilKes PhilKes changed the title Dynamic colors Support Wallpaper color themes Dec 28, 2024
@PhilKes
Copy link
Owner

PhilKes commented Dec 28, 2024

I have not implemented any theming based on wallpaper colors, since I am not aware of such functions, I guess I am a more stock android user, lol. But I can have a look into it, I am guessing android provides built-in support to inject these wallpaper colors into the app's theme.

For other issues/suggestions for the general theme, please add a separate issue. About the custom notes colors, I didnt change any of them, so I'm not sure what has changed there? About covering the whole page, when I re-created the theme I tried to implement this as well but just stopped because of christmas coming up and not knowing when I can come back to development before releasing a new version. I alos thought that it was cleaner to truely only color the note, not the entire app with all navigation bars, dialogs, popupmenus, since that was much more effort and could potentially also lead to constrast issues again. But if most people really want this, I can implement it, just open another issue to keep thing in order here.

@PranshulGG
Copy link
Contributor

@PhilKes Dynamic colors were introduced in Android 12, where the system extracts the palette from your wallpaper and applies the theme to the app. If you don’t mind, I can work on this :P

@PhilKes
Copy link
Owner

PhilKes commented Jan 27, 2025

@PranshulGG are you working on this?
Because I would maybe like to include this in the next version

@PranshulGG
Copy link
Contributor

@PranshulGG are you working on this? Because I would maybe like to include this in the next version

Well, nope, I couldn’t get time to start it ‘cause I had a rough start to the year :/

@PhilKes
Copy link
Owner

PhilKes commented Jan 28, 2025

@PranshulGG are you working on this? Because I would maybe like to include this in the next version

Well, nope, I couldn’t get time to start it ‘cause I had a rough start to the year :/

No worries, I hope your year is getting better soon.
If you want to work on something in the future just let me know 🙂

@PranshulGG
Copy link
Contributor

@PhilKes It's not hard, you just have to use the colors that the system provides.

So, changes in themes.xml would look like this:

<item name="colorPrimary">@color/md_theme_primary</item>

To

<item name="colorPrimary">?attr/colorPrimary</item>

And to my knowledge, it switches to a purple accent if the device doesn't support Material You

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request high priority
Projects
None yet
Development

No branches or pull requests

3 participants