Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle user un-enrolling device biometrics while biometric lock is enabled #238

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

PhilKes
Copy link
Owner

@PhilKes PhilKes commented Jan 14, 2025

Fixes #229

If the biometric lock is enabled, and the app should be locked, but the user un-enrolled all Biometrics/PIN a new dialog appears, asking to the user to either setup biometrics again or to disable biometric lock:

notallyx_issues_229.webm

Notes:

  • If NotallyX was unlocked, the user removes all biometrics and then immediately jumps back to NotallyX the new dialog will not appear since the app hasnt been locked in the mean time. The dialog will appear if the user re-starts the app or locks the device again (which require pin or biometrics to be re-setup)
  • Disabling biometric lock also means decrypting the database, which requires the encryption key. Usually this encryption key is itself only stored encrypted in the preferences, therefore there is no way to decrypt it without the corresponding BiometricPrompt. To be able to decrypt the database when the user removed all biometrics, the encryption key is also stored as a fallback in EncryptedPreferences when the user initially enables the biometric lock

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Handle user unenrolling device biometrics while biometric lock is enabled
1 participant