Split test action into two jobs #1342
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The split test checks took 1m 49s for the tests, and 2m 1s for the coverage, down from 3m 0s for the combined check on #3591. |
jasonaowen
force-pushed
the
split-test-coverage
branch
from
3c6c9fe to
eaa2b6d
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1342 +/- ##
=======================================
Coverage 87.34% 87.34%
=======================================
Files 185 185
Lines 2387 2387
Branches 321 321
=======================================
Hits 2085 2085
Misses 276 276
Partials 26 26 ☔ View full report in Codecov by Sentry. |
slifty
approved these changes
Dec 2, 2024
The GitHub Action for running our tests was doing two things: checking that the tests passed, and then generating and uploading a test coverage report. Unfortunately, our tests are somewhat slow, so running them twice in the same job takes a few minutes. Split them up so they can be run in parallel.
jasonaowen
force-pushed
the
split-test-coverage
branch
from
eaa2b6d to
0766c3e
Compare
I don't think I remember that; tell me more? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The GitHub Action for running our tests was doing two things: checking that the tests passed, and then generating and uploading a test coverage report.
Unfortunately, our tests are somewhat slow, so running them twice in the same job takes a few minutes. Split them up so they can be run in parallel.
See also #1333 (comment) .
As with that PR, we'll need to update the branch protection rules.