Use built-in type definitions for uuid #1384
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1384 +/- ##
=======================================
Coverage 87.40% 87.40%
=======================================
Files 186 186
Lines 2413 2413
Branches 325 318 -7
=======================================
Hits 2109 2109
- Misses 278 304 +26
+ Partials 26 0 -26 ☔ View full report in Codecov by Sentry. |
jasonaowen
force-pushed
the
remove-uuid-types
branch
from
7c0688c to
d31d9ae
Compare
bickelj
approved these changes
Dec 17, 2024
| @@ -10320,6 +10313,7 @@ | |||
| "https://github.com/sponsors/broofa", | |||
| "https://github.com/sponsors/ctavan" | |||
| ], | |||
| "license": "MIT", | |||
There was a problem hiding this comment.
Strange that this line was added.
There was a problem hiding this comment.
I noticed that too; I think I updated npm, but I'm not sure what version from, and I can't find anything obvious in the npm changelog. The upstream package.json license hasn't changed in almost a decade.
Version 11 of the uuid library[1] included a migration to TypeScript, so the externally-provided `@types/uuid` is no longer needed. Uninstall it. [1] https://github.com/uuidjs/uuid/blob/main/CHANGELOG.md#1100-2024-10-26
jasonaowen
force-pushed
the
remove-uuid-types
branch
from
d31d9ae to
25816ec
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Version 11 of the uuid library included a migration to TypeScript, so the externally-provided
@types/uuidis no longer needed. Uninstall it.We upgraded to version 11 in PR #1285.