Improve deploy script #1430
Merged
Improve deploy script #1430
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Do not attempt to hide the (non-secret) deployment URL. This makes it easier to troubleshoot. Also cause script to fail when curl fails. Issue #1410
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1430 +/- ##
=======================================
Coverage 86.89% 86.89%
=======================================
Files 210 210
Lines 2731 2731
Branches 383 383
=======================================
Hits 2373 2373
- Misses 329 358 +29
+ Partials 29 0 -29 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Do not attempt to hide the (non-secret) deployment URL. This makes it easier to troubleshoot. Also cause script to fail when curl fails.
Issue #1410