use settings if set globally - do not default

[PhilipDeegan]

Summary by CodeRabbit

• New Features

  • Enhanced settings processing to handle user-supplied configurations earlier during startup, providing prompt error feedback.

• Chores

  • Updated the project configuration timestamp to a new scheduled date.

• Refactor

  • Streamlined logic for checking file existence.
  • Adjusted internal dependencies to better support command-line interface functionality.

[coderabbitai]

Walkthrough

This pull request makes several targeted updates. In the header file, the logging header is replaced with a CLI header. The project configuration file now has an updated DATE value. In the application’s create method, the settings file handling is moved earlier in the control flow for prompt error checking. Additionally, the conditional in the settings instance method is reformatted for brevity without altering its logic.

Changes

File(s)	Change Summary
inc/maiken/settings.hpp, mkn.yaml	In settings.hpp, the include directive was changed from "mkn/kul/log.hpp" to "mkn/kul/cli.hpp". In mkn.yaml, the DATE value was updated from 20-FEB-2025 to 11-MAR-2025.
src/maiken/create.cpp, src/settings.cpp	In create.cpp, settings file processing was moved earlier in the control flow with improved error handling. In settings.cpp, a multi-line conditional was condensed to a single-line format.

Sequence Diagram(s)

sequenceDiagram
  participant App as Application
  participant Args as Arguments
  participant Set as Settings
  
  App->>Args: Check for help/version & settings arg
  alt Settings argument provided
    App->>Set: Execute SET(settings)
    alt SET operation fails
      Set-->>App: Return error
      App->>App: Exit with error
    else SET operation succeeds
      Set-->>App: Return success
    end
  end
  App->>Set: Call INSTANCE()
  Set->>Set: Run POST_CONSTRUCT()

Loading

Poem

Hopping through code with eager feet,
I change headers and dates so neat.
Command-line magic replaces logs anew,
Settings set early for a smoother debut.
With a whisker wiggle and a joyful leap,
This rabbit cheers as clean code we keep! 🐇

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between aea3964 and 9bb837c.

📒 Files selected for processing (4)

• inc/maiken/settings.hpp (1 hunks)
• mkn.yaml (1 hunks)
• src/maiken/create.cpp (1 hunks)
• src/settings.cpp (1 hunks)

⏰ Context from checks skipped due to timeout of 90000ms (7)

• GitHub Check: Python 3.12
• GitHub Check: build (macos-latest)
• GitHub Check: Python 3.11
• GitHub Check: build
• GitHub Check: build
• GitHub Check: build (macos-14)
• GitHub Check: build

🔇 Additional comments (4)

mkn.yaml (1)

6-6: Updated property date value

The date property has been updated from "20-FEB-2025" to "11-MAR-2025", reflecting a more recent timestamp.

src/settings.cpp (1)

105-105: Simplified conditional statement format

The code has been refactored to use a more concise single-line format for the conditional statement without altering functionality.

inc/maiken/settings.hpp (1)

35-35: Replaced logging header with CLI header

Changed from including "mkn/kul/log.hpp" to "mkn/kul/cli.hpp", which aligns with the PR objective of improving settings handling via command-line arguments.

src/maiken/create.cpp (1)

189-194: Improved settings handling flow

The settings handling has been moved earlier in the control flow to check for explicit settings before defaulting. This change properly prioritizes user-specified settings from command-line arguments, aligning with the PR's objective to "use settings if set globally - do not default."

✨ Finishing Touches

• 📝 Generate Docstrings

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.