Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prompt function does not return a value #51

Open
Froz3nArcher opened this issue May 19, 2017 · 1 comment
Open

Prompt function does not return a value #51

Froz3nArcher opened this issue May 19, 2017 · 1 comment

Comments

@Froz3nArcher
Copy link

RvizVisualTools.prompt calls RemoteControl.waitForNextStep, which calls RemoteControl.rvizDashboardCallback. The prompt function gives no return, so there's no indication that of what the input was from the remote control. rvizDashboardCallback can handle up to four inputs, but waitForNextStep only offers a boolean output, which is then lost in the prompt function.

waitForNextStep and prompt should be modified to propagate the user's desired response in order to correctly handle the interface. There is currently no way to stop an activity using the prompt function - any response simple continues the sequence.

@davetcoleman
Copy link
Member

There is currently no way to stop an activity using the prompt function

Ctrl-C would stop it ;-)

The other buttons are not fully implemented but could be used to stop the process.

A pull request is welcomed for improving the functionality of this package - though big changes would likely need to go into the lunar release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants