-
Notifications
You must be signed in to change notification settings - Fork 5.3k
Feat/paystack export transactions #16551
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Feat/paystack export transactions #16551
Conversation
@tkalejaiye is attempting to deploy a commit to the Pipedreamers Team on Vercel. A member of the Team first needs to authorize it. |
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Skipped Deployment
|
WalkthroughA new "Export Transactions" action was introduced for the Paystack integration, enabling users to export transaction data with optional filtering by date range and status. This feature is implemented via a new method in the Paystack app module, which communicates with the Paystack API's Changes
Sequence Diagram(s)sequenceDiagram
participant User
participant ExportAction
participant PaystackApp
participant PaystackAPI
User->>ExportAction: Trigger export action (with optional filters)
ExportAction->>PaystackApp: Call exportTransactions(args)
PaystackApp->>PaystackAPI: Request /transaction/export (with filters)
PaystackAPI-->>PaystackApp: Return export response
PaystackApp-->>ExportAction: Return response
ExportAction-->>User: Show export summary and response
Suggested labels
Poem
Warning There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure. 🔧 ESLint
components/paystack/actions/export-transactions/export-transactions.mjsOops! Something went wrong! :( ESLint: 8.57.1 Error [ERR_MODULE_NOT_FOUND]: Cannot find package 'jsonc-eslint-parser' imported from /eslint.config.mjs components/paystack/actions/fetch-transaction/fetch-transaction.mjsOops! Something went wrong! :( ESLint: 8.57.1 Error [ERR_MODULE_NOT_FOUND]: Cannot find package 'jsonc-eslint-parser' imported from /eslint.config.mjs components/paystack/actions/initialize-transaction/initialize-transaction.mjsOops! Something went wrong! :( ESLint: 8.57.1 Error [ERR_MODULE_NOT_FOUND]: Cannot find package 'jsonc-eslint-parser' imported from /eslint.config.mjs
📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (6)
✅ Files skipped from review due to trivial changes (5)
🚧 Files skipped from review as they are similar to previous changes (1)
⏰ Context from checks skipped due to timeout of 90000ms (2)
✨ Finishing Touches
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
Thank you so much for submitting this! We've added it to our backlog to review, and our team has been notified. |
Thanks for submitting this PR! When we review PRs, we follow the Pipedream component guidelines. If you're not familiar, here's a quick checklist:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
🧹 Nitpick comments (1)
components/paystack/actions/export-transactions/export-transactions.mjs (1)
40-43
: Consider handling empty parametersThe current implementation passes all parameters to the API, even if they're undefined. Consider filtering out undefined values to avoid sending unnecessary parameters.
const params = { from: this.from, to: this.to, status: this.status, }; + // Filter out undefined parameters + const filteredParams = Object.fromEntries( + Object.entries(params).filter(([_, value]) => value !== undefined) + ); const response = await this.paystack.exportTransactions({ $, - params, + params: filteredParams, });
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (3)
components/paystack/actions/export-transactions/export-transactions.mjs
(1 hunks)components/paystack/package.json
(1 hunks)components/paystack/paystack.app.mjs
(1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (4)
- GitHub Check: Verify TypeScript components
- GitHub Check: pnpm publish
- GitHub Check: Publish TypeScript components
- GitHub Check: Lint Code Base
🔇 Additional comments (3)
components/paystack/paystack.app.mjs (1)
243-248
: LGTM: New method for exporting transactionsThe
exportTransactions
method is well-implemented, following the same pattern as other API methods in this file. It correctly uses the/transaction/export
endpoint and properly passes through any additional arguments.components/paystack/actions/export-transactions/export-transactions.mjs (1)
1-32
: Action definition looks goodThe action is well-defined with appropriate key, name, description, and proper prop definitions referencing the Paystack app. The optional filters for date range and status are correctly implemented.
components/paystack/package.json (1)
3-3
: Version bump is appropriateThe package version increment from 0.2.1 to 0.2.2 follows semantic versioning principles for adding new functionality in a backward-compatible way.
WHY
Adds the export transaction action
Summary by CodeRabbit
New Features
Chores