Avoid repeating the creation of EigenData instances #35
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This heretofore was being created in the NEI class, which slowed down execution. By moving it to eigenclass.py, it should only run once on import. Ultimately, this should be relegated to an HDF5 file so that the calculations need not be repeated. It could also be helpful to store this information in the new data classes available from Python 3.7 on.
|
The html doc builds in CircleCI are failing for a different problem described in #37. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR moves the creation of
EigenDatainstances from theNEIclass to the file thatEigenDatais defined in. Before this, every timeNEIwas instantiated, a new dictionary containing eigendata arrays was calculated, which slowed things down when running models. This will slow down the import ofplasmapy_nei, but this should speed up running models. Ultimately, the eigendata should be put into a new HDF5 file so that it does not need to be calculated.