Fix C stack overflow with dumpvar/exportvar

PlutoLang · Jan 22, 2025 · 21f85ab · 21f85ab
1 parent 1d46d41
commit 21f85ab
Show file tree

Hide file tree

Showing 2 changed files with 16 additions and 0 deletions.
diff --git a/src/lbaselib.cpp b/src/lbaselib.cpp
@@ -692,13 +692,17 @@ static void luaB_dumpvar_impl (lua_State *L, int indents, std::unordered_set<Tab
     dump.append(indents, '\t');
     dump.push_back('[');
     lua_pushvalue(L, -2);
+    luaE_incCstack(L);
     luaB_dumpvar_impl(L, indents + 1, parents, is_export, true);
+    L->nCcalls--;
     dump.append(lua_tostring(L, -1));
     lua_pop(L, 2);
     dump.append("] = ");
 
     lua_pushvalue(L, -1);
+    luaE_incCstack(L);
     luaB_dumpvar_impl(L, indents + 1, parents, is_export);
+    L->nCcalls--;
     dump.append(lua_tostring(L, -1));
     lua_pop(L, 2);
     dump.append(",\n");

diff --git a/testes/pluto/basic.pluto b/testes/pluto/basic.pluto
@@ -1598,6 +1598,18 @@ do
     end
     assert(select(2, pcall(overflow_enc)) == "C stack overflow")
 end
+do
+    local root = {}
+    do
+        local prev_t = root
+        for i = 1, 1000 do
+            local t = {}
+            prev_t:insert(t)
+            prev_t = t
+        end
+    end
+    assert(select(2, pcall(|| -> dumpvar(root))) == "C stack overflow")
+end
 do
     local xml = require "pluto:xml"