Skip to content

Improve subsampling and dataset downloads #2323

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

nikhilwoodruff
Copy link
Collaborator

Fixes #2322
Fixes #2321

@nikhilwoodruff nikhilwoodruff requested a review from anth-volk April 2, 2025 11:19
@nikhilwoodruff nikhilwoodruff self-assigned this Apr 2, 2025
@nikhilwoodruff nikhilwoodruff added the enhancement New feature or request label Apr 2, 2025
Copy link

codecov bot commented Apr 2, 2025

Codecov Report

Attention: Patch coverage is 28.57143% with 5 lines in your changes missing coverage. Please review.

Project coverage is 75.37%. Comparing base (58241ba) to head (b484710).
Report is 6 commits behind head on master.

Files with missing lines Patch % Lines
...ngine_api/jobs/calculate_economy_simulation_job.py 28.57% 5 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2323      +/-   ##
==========================================
- Coverage   77.16%   75.37%   -1.80%     
==========================================
  Files          88       88              
  Lines        3377     3484     +107     
  Branches      366      395      +29     
==========================================
+ Hits         2606     2626      +20     
- Misses        703      788      +85     
- Partials       68       70       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@nikhilwoodruff nikhilwoodruff requested a review from anth-volk April 4, 2025 09:43
Copy link
Collaborator

@anth-volk anth-volk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apologies for the delay in review @nikhilwoodruff. This looks good to me, but I'll let you merge (or modify) in case there's been any change in need here, given some other subsampling-related changes we've made.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enable US subsampling with new Core fixes Ensure US model always downloads datasets from HuggingFace
2 participants