-
Notifications
You must be signed in to change notification settings - Fork 118
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
API Architecture doc blog post #2345
base: master
Are you sure you want to change the base?
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @mikesmit, thanks for your work on this. I limited the scope of my review to the technical implementation, as Max would be responsible for language, but did note a required change before we can merge.
src/posts/posts.json
Outdated
{ "title": "How We're Improving our API in 2025", | ||
"description": "PolicyEngine's API target architecture for 2025.", | ||
"date": "2025-02-05", | ||
"tags": ["technical"], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
important, blocking: Please add "global" as a tag
At the moment, all posts require a geographic tag to be displayed on the site.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! Will fix.
1fec76e
to
e99d4aa
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great @mikesmit! If you could just run the linter and merge, pending approval of the content, this will be good to merge.
e99d4aa
to
3065229
Compare
3065229
to
95a231e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you run make format
to pass lint? Please also confirm you tested it locally.
"date": "2025-02-05", | ||
"tags": ["technical", "global"], | ||
"authors": ["michael-smit"], | ||
"filename": "policyengine_api_v2.md", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We use dashes by convention. Don't think we need policyengine in the URL. Please also rename image as the same.
"filename": "policyengine_api_v2.md", | |
"filename": "api-v2.md", |
fixes #2344