Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use ?? instead of || in getPersistedProperty #136

Merged
merged 1 commit into from
Dec 14, 2023
Merged

Use ?? instead of || in getPersistedProperty #136

merged 1 commit into from
Dec 14, 2023

Conversation

chfinst
Copy link
Contributor

@chfinst chfinst commented Dec 14, 2023

Problem

Changes

This resolved #133

Release info Sub-libraries affected

Bump level

  • Major
  • Minor
  • Patch

Libraries affected

  • All of them
  • posthog-web
  • posthog-node
  • posthog-react-native

Changelog notes

@chfinst chfinst requested a review from marandaneto as a code owner December 14, 2023 08:25
benjackwhite
benjackwhite reviewed Dec 14, 2023
View reviewed changes
Copy link
Collaborator

@benjackwhite benjackwhite left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh wow that is definitely what it originally should have been. Interesting to see if this affects any other functions...

@marandaneto
Copy link
Member

Oh wow that is definitely what it originally should have been. Interesting to see if this affects any other functions...

I let CI run and tests are green at least.

@marandaneto marandaneto merged commit 42183eb into PostHog:master Dec 14, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@benjackwhite benjackwhite benjackwhite left review comments

@marandaneto marandaneto marandaneto approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

OptIn not possible when enable=false
3 participants
@chfinst @marandaneto @benjackwhite