Fix static extension #19
Conversation
| @@ -85,7 +87,11 @@ function set_default_option { | |||
| } | |||
|
|
|||
| function set_default_options { | |||
| set_default_option "$1" "format" "bestvideo+bestaudio/best" | |||
| defaultformat="$(cat "default-format")" | |||
There was a problem hiding this comment.
I'd suggest the path META/default-format instead of ./default-format
There was a problem hiding this comment.
besides that I'd prefer to stay consistent with how the script handles options. that would mean to create the option file, e.g. set_default_global_option "default-format" "bestvideo+bestaudio/best".
There was a problem hiding this comment.
to create the option file
oh, I now realize you've committed the option file to the repo. I wouldn't do that. Besides, cat "default-format" refers to ./default-format, and the yt-sync script doesn't neccessarily need to resist in the PWD.
There was a problem hiding this comment.
I'd suggest the path
META/default-formatinstead of./default-format
If i understand correctly the META directory is for saving the metadata about the channels and videos...i dont understand exactly why saving the config-file in an extra META directory would have any advantage. But i also don't really care about how the maintainer wants to structure the codebase. So, just let me know how and why you want it ;)
|
fwiw, there are some spelling errors: |
|
@PotcFdk Can i get your jabber-id to chat with you directly? havent found a way to contact you on your website. |
|
@thrdroom I haven't had the time to do the required maintenance on my XMPP daemon yet, but I can offer IRC instead. |
|
The results of the discussion can be seen in #11. |
This changes should fix #18
I removed the hardcoded mkv file extension from the sync function and implemented a remux function in case youtube-dl is downloading a mp4 instead of a mkv. This method also opens the possibility of allowing more containers other than mkv in the future.
I also outsourced the default format into a separate settings file, for better usability. This way the user don't have to change the source code of the youtube-sync file to change the default format.