Request for catalog listing access for finding packages #1824
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adityapatwardhan
requested review from
anamnavi,
alerickson and
SydneyhSmith
as code owners
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| return null; | ||
| } | ||
|
|
||
| request.Content = new StringContent(content); |
Check warning
Code scanning / CodeQL
Information exposure through transmitted data
Show autofix suggestion
Hide autofix suggestion
Copilot Autofix
AI 4 days ago
To fix the issue, the sensitive data (password) should not be directly included in the content variable. Instead, the code should use a secure mechanism to transmit authentication information, such as an encrypted token or a secure header. If the password must be used, it should be hashed or encrypted before transmission. Additionally, the code should ensure that sensitive data is not logged or exposed in error messages.
The fix involves:
- Modifying the
Utils.GetContainerRegistryAccessTokenFromSecretManagementmethod to return a secure token instead of a plaintext password. - Updating the
contentvariable inContainerRegistryServerAPICalls.csto use the secure token instead of the password. - Ensuring that sensitive data is not logged or exposed in error messages.
Suggested changeset
2
src/code/ContainerRegistryServerAPICalls.cs
| @@ -552,3 +552,3 @@ | ||
| _cmdletPassedIn.WriteDebug("In ContainerRegistryServerAPICalls::GetContainerRegistryRefreshToken()"); | ||
| string content = string.Format(containerRegistryRefreshTokenTemplate, Registry, tenant, accessToken); | ||
| string content = string.Format(containerRegistryRefreshTokenTemplate, Registry, tenant, Convert.ToBase64String(Encoding.UTF8.GetBytes(accessToken))); | ||
| var contentHeaders = new Collection<KeyValuePair<string, string>> { new KeyValuePair<string, string>("Content-Type", "application/x-www-form-urlencoded") }; |
src/code/Utils.cs
Outside changed files
| @@ -719,3 +719,4 @@ | ||
| string password = new NetworkCredential(string.Empty, secretSecureString).Password; | ||
| return password; | ||
| string secureToken = Convert.ToBase64String(Encoding.UTF8.GetBytes(password)); | ||
| return secureToken; | ||
| } | ||
| @@ -724,3 +725,4 @@ | ||
| string password = new NetworkCredential(string.Empty, psCredSecret.Password).Password; | ||
| return password; | ||
| string secureToken = Convert.ToBase64String(Encoding.UTF8.GetBytes(password)); | ||
| return secureToken; | ||
| } |
Copilot is powered by AI and may make mistakes. Always verify output.
Unable to commit as this autofix suggestion is now outdated
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
adityapatwardhan
force-pushed
the
FixCatalogAccess
branch
from
d861075 to
134f71e
Compare
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
This pull request introduces enhancements to the
ContainerRegistryServerAPICallsclass, focusing on improving the handling of access tokens, adding support for catalog-specific scopes, and refining error handling and debugging. The most significant changes include adding aneedCatalogAccessparameter to methods dealing with authentication, updating templates for URL and content formatting, and improving debugging and error reporting.Authentication and Scopes:
needCatalogAccessparameter to theGetContainerRegistryAccessTokenandIsContainerRegistryUnauthenticatedmethods to support catalog-specific access tokens. This allows finer control over authentication based on whether catalog access is needed. (src/code/ContainerRegistryServerAPICalls.cs, [1] [2]grantTypeTemplateandauthUrlTemplate) to dynamically include catalog scope whenneedCatalogAccessis true. (src/code/ContainerRegistryServerAPICalls.cs, [1] [2]Error Handling and Debugging:
FindPackagesWithVersionHelperby skipping invalid NuGet package versions instead of returningnull. Added debug logs to provide detailed information about skipped packages. (src/code/ContainerRegistryServerAPICalls.cs, src/code/ContainerRegistryServerAPICalls.csL1764-R1781)IsContainerRegistryUnauthenticatedto log error records when failing to retrieve anonymous access tokens. (src/code/ContainerRegistryServerAPICalls.cs, src/code/ContainerRegistryServerAPICalls.csL485-R504)Code Refinements:
GetHttpResponseJObjectUsingContentHeadersto ensure HTTP GET requests do not include a body, adhering to HTTP standards. (src/code/ContainerRegistryServerAPICalls.cs, [1] [2]PR Context
In some non-microsoft tenants, finding packages was not working.
PR Checklist
.h,.cpp,.cs,.ps1and.psm1files have the correct copyright headerWIP:or[ WIP ]to the beginning of the title (theWIPbot will keep its status check atPendingwhile the prefix is present) and remove the prefix when the PR is ready.