lab1 #3
Merged
lab1 #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SkivHisink
approved these changes
Mar 7, 2025
| #include "models/sub_task.hpp" | ||
|
|
||
| namespace Worker { | ||
| class LexicographicWordGenerator { |
| size_t wordsPerPart = totalWords / subTask.partCount; | ||
| size_t remainingWords = totalWords % subTask.partCount; | ||
|
|
||
| std::cout << "subTask.partNumber: " << subTask.partNumber << std::endl; |
There was a problem hiding this comment.
Конструктор должен принимать поток куда писать, чтобы у нас была возможность выбора куда мы пишем
| #include <string> | ||
|
|
||
| #include "models/crack_request.hpp" | ||
| #include "userver/formats/serialize/to.hpp" |
There was a problem hiding this comment.
В большинстве случаев для userver используете <>, а тут почему-то ""
There was a problem hiding this comment.
И порядок include'ов тут отличается от всех остальных файлов
|
|
||
| #include <userver/components/component_list.hpp> | ||
| #include <userver/server/handlers/http_handler_json_base.hpp> | ||
|
|
|
|
||
| #include <userver/components/component_list.hpp> | ||
| #include <userver/server/handlers/http_handler_json_base.hpp> | ||
|
|
| #include "models/crack_request.hpp" | ||
|
|
||
| namespace Manager { | ||
|
|
There was a problem hiding this comment.
Я бы так делал в *.cpp и читабильность была бы x10:
using HttpHandlerJsonBase = userver::server::handlers::HttpHandlerJsonBase;
using HttpRequest = userver::server::http::HttpRequest;
using HttpStatus = userver::server::http::HttpStatus;
using HttpMethod = userver::server::http::HttpMethod;
using ClientError = userver::server::handlers::ClientError;
using Value = userver::formats::json::Value;
using ValueBuilder = userver::formats::json::ValueBuilder;
using RequestContext = userver::server::request::RequestContext;
There was a problem hiding this comment.
Но это необязательно, как вам удобнее.
There was a problem hiding this comment.
Думал о таком, но привык, когда using для сокращений полных путей используются по минимуму
|
|
||
| #include <userver/components/component_list.hpp> | ||
| #include <userver/server/handlers/http_handler_json_base.hpp> | ||
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.