Add hook actionMainMenuModifier

[bibips]

Questions	Answers
Description?	Allow main menu to be extended by other modules thanks a new hook actionMainMenuModifier. Thanks this hook it's possible to have menu items specific per customer by example.
Type?	improvement
BC breaks?	no
Deprecations?	no
Fixed ticket?	No issue
How to test?	Register hook actionMainMenuModifier and add or edit something into main menu

Hook usage :

    public function hookActionMainMenuModifier(array $hookParams)
    {
          $hookParams['menu']['children'][] = [
              'type' => 'link',
              'label' => $this->trans('Test', [], 'Modules.Test.Menu'),
              'url' => $this->context->link->getModuleLink($this->name, 'pickup'),
              'depth' => 1,
              'children' => [],
              'open_in_new_window' => "0",
              'page_identifier' => $this->trans('Test', [], 'Modules.Test.Menu'),
              'current' => false
          ];
    }

[Hlavtox]

Wouldn't it be better if you could change the $menu variable instead? With this solution, you can display things only after the list, but cannot modify the items.

[bibips]

Wouldn't it be better if you could change the $menu variable instead? With this solution, you can display things only after the list, but cannot modify the items.

I like this Idea

[bibips]

@Hlavtox @M0rgan01 any updates for this PR ?

[M0rgan01]

Sorry, I lost the thread! Yes it's ok for me :) You will need to add the new hook on the core side (in hook.xml file)

[Hlavtox]

@M0rgan01 I think we shouldn't, the core should include no data or references to any modules I think.

[M0rgan01]

I thought that was the case :) Everything is good

[AureRita]

Hi @bibips

Thank you for your PR, I tested it and unfortunately this one doesn't works as expected as you can see :

Indeed, the "use Hook;" doesn't seems to works and, because of that, the hook isn't accessible

Thank you

[bibips]

@AureRita Excuse me for the delay, I've removed use Hook; as suggested

[jtraulle]

This would be a great addition for external modules to be able to add links to the main menu.
Anything missing here @AureRita for this to be merged ?

[Hlavtox]

I don't see much value in this… isn't the sole purpose of menu that it's purely configurable by people?

Do you have any real use case for this hook?

[bibips]

I don't see much value in this… isn't the sole purpose of menu that it's purely configurable by people?

Do you have any real use case for this hook?

Hi @Hlavtox,

I've created this hook to add or remove menu items according some criterias. By instance in my shop I have a menu item only available for a group of customer. Thanks to this hook, we can check if the customer is logged in or if the customer matches certain criteria (such as country, device type, customer configuration, etc...) before making a menu item available.

Without this hook, we can't.

[bibips]

Hi @Hlavtox,

Does this use case convince you of the hook's usefulness ?

[jolelievre]

Thanks @bibips

The explained use case makes sense to me and there are probably many others. The implementation is also ok so I dismiss your blocker for now @Hlavtox.
If you are other worries don't hesitate to re-review