fix: make fingerprint feature deterministic #151
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using Python's built-in hash is not consistent between runs due to salting.
Thus, the fingerprint feature using the built-in hash is not deterministic, making the input data non-deterministic and making the predictions non-deterministic between runs. Hashlib's hash is consistent between runs and thus does not face this problem.
This broke during the refactoring. The commit below is essentially reverting a commit that happened during the refactor.
FYI: @eddiebergman