Fix phe and hpo with TabPFN API #9
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I like the change as this moves some more of the shared funcs into the common package! Would you move things from the main TabPFN package into the shared utils too? |
noahho
approved these changes
Jan 16, 2025
|
This still works with the non-client, i.e. with the local package? If yes LGTM |
|
Waiting for the new tabpfn package release to merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The PHE and HPO break in a bunch of way with the client. This PR (jointly with a server PR and a client PR fix these issues. This
tabpfn-extensionsPR:categorical_features_indices(the client doesn't use it for now so we just output a warning)