Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix deserialization of authorizations with multiple transitions #2479

Open
wants to merge 3 commits into
base: staging
Choose a base branch
from

Conversation

lukenewman
Copy link

@lukenewman lukenewman commented Jun 6, 2024

Motivation

When deserializing an Authorization from string a call stack that included multiple transitions, the structural assertion logic would erroneously fail. This PR fixes the assertion logic but does not change the underlying structure/order of the Authorization fields.

Test Plan

Added two unit tests for authorization deserializations:

  • single transition is in synthesizer/process/src/stack/authorization/mod.rs
  • multiple transitions is in synthesizer/src/vm/mod.rs

I'm happy to relocate the latter to authorization/mod.rs but stuck it in vm/mod.rs since it needs to deploy two programs to the test VM.

Related PRs

none

@vicsn
Copy link
Collaborator

vicsn commented Jun 6, 2024

Great find!

embedding a multi-transition Authorization unit test

Yes please. You can see some recent examples of adjusted tests in ledger/src/tests.rs in: https://github.com/ProvableHQ/snarkVM/pull/13/files . There are also a lot in synthesizer/src/vm/mod.rs

@lukenewman lukenewman changed the title Authorization deserialization fix Fix deserialization of authorizations with multiple transitions Jan 31, 2025
@lukenewman lukenewman marked this pull request as ready for review January 31, 2025 22:55
@lukenewman
Copy link
Author

@vicsn this is good for another pass! added unit tests

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants