Refactor CallStack::Synthesize to produce consistent dummy outputs for faster nested import deployments #2598
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
NOTE: this PR will also significantly speed up tests using nested deployments, e.g. |
vicsn
requested changes
Jan 21, 2025
vicsn
reviewed
Jan 22, 2025
vicsn
reviewed
Jan 22, 2025
|
note: the failing |
|
@d0cd This may be relevant to some of your |
vicsn
reviewed
Jan 26, 2025
| impl<N: Network> StackKeys<N> for Stack<N> { | ||
| /// Returns `true` if the proving key for the given function name exists. | ||
| #[inline] | ||
| fn contains_proving_key(&self, function_name: &Identifier<N>) -> bool { |
There was a problem hiding this comment.
Now that these functions are defined in impl<N: Network> StackKeys<N> for Stack<N>, can they be removed in impl<N: Network> Stack<N>?
There was a problem hiding this comment.
Good catch, addressed here: 46c8498
vicsn
approved these changes
Jan 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR refactors the way
CallStack::Synthesizeis run, decoupling theSynthesizemode from the oldexecute_functionapproach. It produces consistent dummy outputs (inspired byCheckDeployment) more rapidly and skips sub-circuit construction for nested import calls. The result is significantly faster deployments for deeply nested imports, while still generating cryptographically coherent record nonces.Motivation
Previously,
AuthorizeandSynthesizemodes were lumped together. As such, calls in CallStack::Synthesize were forced to run a real sub-circuit viaexecute_function. This is slow for nested imports and has led to an exponential growth in deployment time w.r.t. the import depth.Thus, this PR refactors the
Synthesizebranch to skip full circuit execution and produce “dummy” outputs with consistent record nonces.Note
This PR changes expected future IDs in 3 of the
execute_and_finalizetests. The reason is that previously, Synthesize always ran real sub-circuits, consuming RNG draws. With this PR, certain sub-circuits are skipped by producing dummy outputs. As a result, the RNG is executed less times, leading to different transaction commitments and future IDs.Test Plan
Tested the deployment and execution of programs with deep imports in a local devnet.
Related PRs