-
Notifications
You must be signed in to change notification settings - Fork 21
ci: add installation tests for all supported OS and python versions #43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Welcome to Codecov 🎉Once you merge this PR into your default branch, you're all set! Codecov will compare coverage reports and display results in all future pull requests. Thanks for integrating Codecov - We've got you covered ☂️ |
6fb4e86
to
af75f2d
Compare
5330ca4
to
c2a9591
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Description
This PR adds workflows to check the installation of
pruna
on various OS and Python versions to avoid issues like #21 in the future. I am open for discussion on this but generally felt like this is not something that should happen on every commit, but rather on dispatch when the PR necessitates it and once as a sanity check when merging to main.Related Issue
Avoid #21 in the future
Type of Change
How Has This Been Tested?
Ran the workflows on this PR. Currently Python 3.12 on ubuntu is failing which is intended, the rest pass.
Checklist
Additional Notes
None.