Skip to content

ci: add installation tests for all supported OS and python versions #43

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Apr 1, 2025

Conversation

johannaSommer
Copy link
Collaborator

@johannaSommer johannaSommer commented Mar 31, 2025

Description

This PR adds workflows to check the installation of pruna on various OS and Python versions to avoid issues like #21 in the future. I am open for discussion on this but generally felt like this is not something that should happen on every commit, but rather on dispatch when the PR necessitates it and once as a sanity check when merging to main.

Related Issue

Avoid #21 in the future

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Ran the workflows on this PR. Currently Python 3.12 on ubuntu is failing which is intended, the rest pass.

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

Additional Notes

None.

Copy link

codecov bot commented Mar 31, 2025

Welcome to Codecov 🎉

Once you merge this PR into your default branch, you're all set! Codecov will compare coverage reports and display results in all future pull requests.

Thanks for integrating Codecov - We've got you covered ☂️

@johannaSommer johannaSommer force-pushed the ci/installation-tests branch from 6fb4e86 to af75f2d Compare March 31, 2025 13:03
@johannaSommer johannaSommer marked this pull request as ready for review March 31, 2025 13:12
@johannaSommer johannaSommer force-pushed the ci/installation-tests branch from 5330ca4 to c2a9591 Compare April 1, 2025 09:26
Copy link
Collaborator

@SaboniAmine SaboniAmine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks!

Copy link
Collaborator

@johnrachwan123 johnrachwan123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@johannaSommer johannaSommer changed the title ci: add installation tests for various OS and python versions ci: add installation tests for all supported OS and python versions Apr 1, 2025
@johannaSommer johannaSommer merged commit 7c43948 into main Apr 1, 2025
8 checks passed
@johannaSommer johannaSommer deleted the ci/installation-tests branch April 1, 2025 21:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants