Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adapt transactions #533

Merged
merged 6 commits into from
Nov 11, 2022
Merged

Adapt transactions #533

merged 6 commits into from
Nov 11, 2022

Conversation

mattgle
Copy link
Contributor

@mattgle mattgle commented Nov 9, 2022

Summary

  • Pass components to TS
  • Delete useless code
  • Adapt getTransactions to work with controller's changes.

Screenshots

image

Github Issue

#528

@mattgle mattgle changed the base branch from develop to 0.4.0 November 9, 2022 18:45
@ignaciosantise ignaciosantise self-requested a review November 9, 2022 19:42
logo: string;
canisterId: string;
details?: { [key: string]: any };
canisterInfo?: Object;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what about the interface CanisterInfo that we have above?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I use the same one as in the Controller cuz otherwise i was getting problems with TS

Copy link
Contributor

@ignaciosantise ignaciosantise left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great 🎉

@ignaciosantise ignaciosantise added the DON'T MERGE Don't merge this label Nov 9, 2022
* Add ActivityDetail modal and pass Profile to TS

* Add toast, add contact label, fix problem opening same activityDetail

* Change type

* Change controllers package
@mattgle mattgle merged commit e93a7a3 into 0.4.0 Nov 11, 2022
@mattgle mattgle deleted the refactor-trx branch November 11, 2022 20:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
DON'T MERGE Don't merge this
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants