Update Chevron in Select to point sideways #633
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since the downwards chevron can be a bit misleading, we are changing it to be a sideways chevron in the 'inVariableBox' version. To better indicate that something will open in the middle of the screen. This contains some refactoring, since some functionality is now shared. Added a function to show 2 different icons based on the language direction, but not sure if this is what we want. The original code for this check is one line, so maybe we just want to use that instead. Would like feedback on this! Also added a 'RTL' part to the Select in Storybook, so we can see how it looks when the direction is reversed!
Deploying pxweb2 with
|
| Latest commit: |
2a1705a
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://ae1b4c81.pxweb2.pages.dev |
| Branch Preview URL: | https://fix-pxweb2-431-change-arrow.pxweb2.pages.dev |
|
SjurSutterudSagen
requested review from
likp,
MikaelNordberg,
KentMossback,
runejo,
PerIngeVaaje,
oyessb and
michaelpande
as code owners
michaelpande
approved these changes
Apr 11, 2025
SjurSutterudSagen
deleted the
fix/PxWeb2-431-change-arrow-in-variableBox-select-to-sideways-arrows
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since the downwards chevron can be a bit misleading, we are changing it to be a sideways chevron in the 'inVariableBox' version. To better indicate that something will open in the middle of the screen.
This contains some refactoring, since some functionality is now shared. Added a function to show 2 different icons based on the language direction, but not sure if this is what we want. The original code for this check is one line, so maybe we just want to use that instead. Would like feedback on this!
Also added a 'RTL' part to the Select in Storybook, so we can see how it looks when the direction is reversed.