Skip to content
This repository was archived by the owner on Apr 29, 2024. It is now read-only.

🐛 Ignore collection failures in non-tests #1

Closed
wants to merge 36 commits into from
Closed

🐛 Ignore collection failures in non-tests #1

wants to merge 36 commits into from

Conversation

stdedos
Copy link

@stdedos stdedos commented Feb 24, 2023 •
edited
Loading

This change applies the pre-existing patterns to identify if the files with collection problems are tests. It is then used to eliminate the false-positives of F6401 (cannot-enumerate-pytest-fixtures).

As a side effect, this patch also includes precise file paths that may be used to reproduce the problem.

Fixes reverbc#20
Fixes reverbc#21

Replayed; Source PR: reverbc#22

Additionally:

Improve F6401:cannot-enumerate-pytest-fixtures:

  • Capture and return stdout and stderr (instead of trashing them)
  • Fix the 'duplicate-path' error by relative-izing the paths before unioning them
  • Update tests to test for both conditions

Additionally:

  • pylint-pytest does not support pylint>=3
  • Fix two used-before-assignment pylint issues (stdout, stderr) 🤪

Signed-off-by: Stavros Ntentos [email protected]

@stdedos stdedos mentioned this pull request Mar 10, 2023
Closed
@stdedos stdedos force-pushed the fix/21-exclude-non-tests branch from 4f82aff to 366bb04 Compare October 12, 2023 14:14
stdedos and others added 10 commits October 14, 2023 11:59
@stdedos
MOAR Improvements: Cross-OS testing, .gitignore updates, supporting…
c5af2e5 
… only `pylint<3`, coverage at Codecov, drop other CI

Signed-off-by: Stavros Ntentos <[email protected]>
@stdedos
Merge pull request #1 from pylint-dev/ci/improve/use-gh-actions
6be0547 
CI: Use GH-Actions, drop the rest, MOAR Pythons, MOAR OSes, coverage at Codecov

Additionally:
* Update `.gitignore`
* Mark the plugin supporting only `pylint<3`
@Pierre-Sassoulas
Add a release job to publish on pypi on github tag creation
56fa1d1
@stdedos
Add .pre-commit-config.yaml
005174f 
Store all tools' configurations in `pyproject.toml`,
even if right now only the `setup.py` file is used.

Keep `.pylintrc` separately.
It is 300 lines; default `--generate-toml-config` gives 600 😅

Comment-out hooks that need >0 work to be green.

Signed-off-by: Stavros Ntentos <[email protected]>
@stdedos
pre-commit run -a
85d7e42 
Signed-off-by: Stavros Ntentos <[email protected]>
@stdedos
Enable https://github.com/asottile/pyupgrade + .git-blame-ignore-revs
ff18b58 
Signed-off-by: Stavros Ntentos <[email protected]>
@stdedos
Merge pull request #5 from pylint-dev/release-job
ab07d5e
@stdedos
Merge pull request #4 from stdedos/ci/pre-commit/config
5ee69ce
@Pierre-Sassoulas
Use ruff instead of flake8 pyupgrade autoflake and isort
ae436ac
@stdedos
Merge pull request #6 from pylint-dev/pre-commit-ruff
a1fc41e
@stdedos stdedos mentioned this pull request Oct 15, 2023
Merged
Pierre-Sassoulas and others added 16 commits October 15, 2023 11:48
@Pierre-Sassoulas
Upgrade the changelog for 1.1.3a0 release (#10)
1c2613b
@Pierre-Sassoulas
Activate ruff, ignore the typing of classvar
ae3d8ca
@Pierre-Sassoulas
[pylint] Add pylint in the continuous integration and pre-commit
ec51408
@Pierre-Sassoulas
Move the pylint configuration to pyproject.toml
0a4331d
@stdedos @Pierre-Sassoulas
Minor re-ordering of the tool.pylint, with some comments
7feeb56 
Signed-off-by: Stavros Ntentos <[email protected]>
@stdedos @Pierre-Sassoulas
Carry over some .pylintrc configuration
a444a61 
Signed-off-by: Stavros Ntentos <[email protected]>
@Pierre-Sassoulas
[mypy] Fix Item "None" of "Optional[Module]" has no attribute "__file__"
122c799
@Pierre-Sassoulas
Activate mypy in pre-commit
33d1313
@stdedos
Fix mypy issues
b65e979 
Most of the issues are "almost clear-cut", except the
astroid stuff - `pylint_pytest/checkers/class_attr_loader.py`.

Those were mostly placated (but hopefully done right).

Additionally, add some sanity features to `BasePytestTester`:
* Marked class as `ABC`
* Enforce subclasses to initialize `MSG_ID`

Mostly both of those changes are "aesthetical",
and do not contribute to strict guarantees of behavior, or type assertions.

But at least `pytest` cries loudly when used wrong - so that's something.

Signed-off-by: Stavros Ntentos <[email protected]>
@stdedos
Roll back from __future__ import annotations for Python 3.6
b8ce4ad 
... and `f{msg_id=}`

Signed-off-by: Stavros Ntentos <[email protected]>
@Pierre-Sassoulas
Merge pull request #9 from pylint-dev/pre-commit-mypy
2d6d83a 
Activate mypy in pre-commit
@stdedos
Fix the repository badges
163ac3a 
Signed-off-by: Stavros Ntentos <[email protected]>
@stdedos
Improvements for .github/workflows/run-tests.yaml
0b1bb86 
* Configure action `concurrency:`
* Use `codecov/codecov-action@v3` flags (might ... help codecov, somehow)
* Upload testing artifacts
* Add the Codecov badge in the README.md

Signed-off-by: Stavros Ntentos <[email protected]>
@stdedos
Merge pull request #14 from stdedos/test/impr-action+coverage
55e4218
@stdedos
Fix testing + coverage
c208abb 
* Drop `py312` to combat #16
* Install `--editable`, so that Python uses the correct source files for coverage
* Ignore `tests/input/**/*.py` from coverage - they are not ran properly
* Again improve on artifact naming

Signed-off-by: Stavros Ntentos <[email protected]>
@stdedos
Merge pull request #18 from stdedos/ci/fix-test-coverage
f8da197
stdedos and others added 9 commits October 19, 2023 09:55
@stdedos
Release v1.1.3rc0 (#17)
4971561 
Additionally, fixes #13

Signed-off-by: Stavros Ntentos <[email protected]>
@stdedos
Improve packaging + Release v1.1.3rc1
85dd457 
* Drop `tests/*` both from `sdist` and `wheel`
* Drop `universal` wheel (we don't support Python2)

Signed-off-by: Stavros Ntentos <[email protected]>
@stdedos
Merge pull request #19 from stdedos/release/v1.1.3rc1
cb653a0 
See more details in #19
@anis-campos
test direct import
630172b
@anis-campos
Fixing _is_pytest_fixture
d5cd873 
currently, both fixture in this example are flagged has not fixtures
```python
from pytest import fixture

@fixture
def my_fixture(): pass

@fixture(name="foo")
def my_fixture_2(): pass
```
This is due to the different semantics in astroid when using `import pytest` or `from pytest import ...`
@stdedos
Release v1.1.3
0a47a49 
Signed-off-by: Stavros Ntentos <[email protected]>
@stdedos
Merge pull request #2 from anis-campos/fix_is_pytest_fixture
a5c6855 
See more details in #2
@stdedos
🐛 Ignore collection failures in non-tests
f6a343d 
This change applies the pre-existing patterns to identify if the files with collection problems are tests. It is then used to eliminate the false-positives of F6401 (cannot-enumerate-pytest-fixtures).

As a side effect, this patch also includes precise file paths that may be used to reproduce the problem.

Fixes reverbc#20
Fixes reverbc#21

Signed-off-by: Sviatoslav Sydorenko <[email protected]>

_Replayed; Source PR: https://github.com/reverbc/pylint-pytest/pull/22_

Additionally, satisfied the https://github.com/pylint-dev/pylint-pytest's `.pre-commit-config.yaml`

Signed-off-by: Stavros Ntentos <[email protected]>
@stdedos
Improve F6401:cannot-enumerate-pytest-fixtures:
abc9f22 
* Capture and return `stdout` and `stderr` (instead of trashing them)
* Fix the 'duplicate-path' error by `relative`-izing the paths before `union`ing them
* Update tests to test for both conditions

Additionally, fix two `used-before-assignment` pylint issues (`stdout`, `stderr`) 🤪

Signed-off-by: Stavros Ntentos <[email protected]>
@stdedos stdedos force-pushed the fix/21-exclude-non-tests branch from 366bb04 to abc9f22 Compare October 23, 2023 08:17
@stdedos stdedos closed this Oct 23, 2023
@stdedos stdedos deleted the fix/21-exclude-non-tests branch October 23, 2023 08:19
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG]Why does adding a module produce F6401 0.3.0 found my fixtures; 1.1.2 cannot.
3 participants
@stdedos @Pierre-Sassoulas @anis-campos