Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update pyo3 to 0.8 and bump version to 0.7 #111

Merged
merged 3 commits into from
Sep 7, 2019
Merged

Conversation

kngwyu
Copy link
Member

@kngwyu kngwyu commented Sep 2, 2019

TODO

  • Modify Cargo.toml when 0.8 is released
  • Check if the module name is appropriate again

@rth
Copy link
Contributor

rth commented Sep 4, 2019

Before the next rust-numpy release, maybe it could make sense to also wait for the release of ndarray 0.13 expected early September rust-ndarray/ndarray#670)?

@kngwyu
Copy link
Member Author

kngwyu commented Sep 4, 2019

Great, thank you for letting me know that.

@kngwyu kngwyu changed the title Update pyo3 to 0.8 Update pyo3 to 0.8 and bump version to 0.7 Sep 7, 2019
@kngwyu
Copy link
Member Author

kngwyu commented Sep 7, 2019

@rth
Since ndarray 0.13 is not yet released, I decided to release rust-numpy 0.7 before the release.
I confirmed that the latest master of ndarray works with rust-numpy and changed the Cargo.toml to ndarray >= 0.12.

@kngwyu kngwyu merged commit e11cc0e into PyO3:master Sep 7, 2019
@kngwyu kngwyu deleted the pyo3-0.8 branch September 7, 2019 06:54
@rth
Copy link
Contributor

rth commented Sep 7, 2019

Sure, that also works. Thanks @kngwyu !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants