-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
domain-driven appends #227
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main-1.0.0 #227 +/- ##
==============================================
+ Coverage 90.86% 92.07% +1.21%
==============================================
Files 93 88 -5
Lines 2386 2272 -114
Branches 178 176 -2
==============================================
- Hits 2168 2092 -76
+ Misses 218 180 -38 ☔ View full report in Codecov by Sentry. |
Description
The PR modifies the way appends are done through the following changes:
When a cube
c
already exists as an inner cube, an elemente
should be accepted ife.weight < c.existingWeight
andcount < groupCubeSize
.When a cube
c
already exists as a leaf cube, itsWeightAndCount
should start with its existing group size and add elements until it's full.mergedCubeDomains
through a cube-wise sum of the existing domain and the append domains.mergedCubeDomains
usingWc = Wpc + dcs / domain
.Fixes #226
The same test from #226 shows that, with these changes, only
0.16%
of the append blocks don't update themaxWeight
of their corresponding cubes.Checklist: