fix: avoid flaky test behavior on macOS (backport #10) #11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![mergify[bot]](https://avatars.githubusercontent.com/in/10562?s=60&v=4){kind=small}
(cherry picked from commit 5a50591)
mrossinek
approved these changes
Sep 13, 2024
Pull Request Test Coverage Report for Build 10848117807Details
💛 - Coveralls |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #8
Although I have not been able to pin-point the reason for the flaky test behavior, tightening the convergence thresholds, disabling warm-starting, and loosening the relative tolerance of the equality check seems to make the flakiness go away.
Prior to this PR, I would see 5-10 failures in 1000 repetitions. After this, I no longer observe any.
This is an automatic backport of pull request #10 done by Mergify.