Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: option to disable legend #20

Merged
merged 7 commits into from
Nov 5, 2024
Merged

feat: option to disable legend #20

merged 7 commits into from
Nov 5, 2024

Conversation

boonware
Copy link
Contributor

@boonware boonware commented Oct 2, 2024

Issue

#19

Description

  • Add a new parameter to each visualization function to disable showing the legend in plots. Defaults to True.
  • Style changes were made via tox -e style.

@BryceFuller

@CLAassistant
Copy link

CLAassistant commented Oct 2, 2024

CLA assistant check
All committers have signed the CLA.

Copy link
Member

@mrossinek mrossinek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please also add a release note which highlights the addition of the show_legend keyword argument to the various visualization functions.

We are still missing the section describing this in our CONTRIBUTING.md guide, but you can have a look here for how that is done.

qiskit_addon_obp/utils/visualization.py Outdated Show resolved Hide resolved
@boonware
Copy link
Contributor Author

@mrossinek Requested changes have been made:

  1. Updated param to be keyword-only.
  2. Added a release note.

@boonware
Copy link
Contributor Author

boonware commented Nov 1, 2024

@mrossinek Can I get another review on this one? Thanks

@coveralls
Copy link

coveralls commented Nov 5, 2024

Pull Request Test Coverage Report for Build 11681029072

Details

  • 15 of 15 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 100.0%

Totals Coverage Status
Change from base Build 11554634560: 0.0%
Covered Lines: 431
Relevant Lines: 431

💛 - Coveralls

@mrossinek mrossinek enabled auto-merge (squash) November 5, 2024 09:20
@boonware
Copy link
Contributor Author

boonware commented Nov 5, 2024

@mrossinek The test case test_backpropagate_timeout is failing. Judging by the name, and the test code, I suspect this is down to a test instability and not related to my changes, which appear unrelated to the test case. Can we run the suite again?

@mrossinek mrossinek merged commit 62bbf57 into Qiskit:main Nov 5, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants