Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace pydocstyle with Ruff #26

Merged
merged 7 commits into from
Oct 24, 2024
Merged

Replace pydocstyle with Ruff #26

merged 7 commits into from
Oct 24, 2024

Conversation

Eric-Arellano
Copy link
Collaborator

@Eric-Arellano Eric-Arellano commented Oct 23, 2024 •
edited by caleb-johnson
Loading

Fixes #25

Pydocstyle was deprecated in favor of Ruff. Ruff has the exact same lints via the D ruleset.

As before, we only run the doc checks on source code and not tests.

@coveralls
Copy link

coveralls commented Oct 23, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 11499671348

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 100.0%
Totals Coverage Status
Change from base Build 11435629779: 0.0%
Covered Lines: 429
Relevant Lines: 429
💛 - Coveralls

@caleb-johnson
Copy link
Collaborator

Thanks @Eric-Arellano , LGTM!

@caleb-johnson caleb-johnson merged commit 6fa4aa1 into Qiskit:main Oct 24, 2024
15 checks passed
@Eric-Arellano Eric-Arellano deleted the EA/rm-pydocstyle branch October 24, 2024 14:01
@Eric-Arellano Eric-Arellano added the stable backport potential Label for mergify to open a backport PR label Oct 28, 2024
@Eric-Arellano
Copy link
Collaborator Author

@Mergifyio backport stable/0.1

@Eric-Arellano Eric-Arellano removed the stable backport potential Label for mergify to open a backport PR label Oct 28, 2024
@mergify Mergify
Copy link

mergify bot commented Oct 28, 2024 •
edited
Loading

backport stable/0.1

✅ Backports have been created

mergify bot pushed a commit that referenced this pull request Oct 28, 2024
@Eric-Arellano @mergify
Replace pydocstyle with Ruff (#26)
854085b 
* Replace pydocstyle with Ruff

* Add to style env

* Configure Google style

* Call a single time

* More precise ignore

* Revert "More precise ignore"

This reverts commit 8d5ff43.

* More precise config

(cherry picked from commit 6fa4aa1)
@mergify mergify bot mentioned this pull request Oct 28, 2024
Merged
Eric-Arellano pushed a commit that referenced this pull request Oct 28, 2024
@mergify
Replace pydocstyle with Ruff (#26) (#30)
26108db 
Fixes #25 

Pydocstyle was deprecated in favor of Ruff. Ruff has the exact same lints via the `D` ruleset.

As before, we only run the doc checks on source code and not tests.<hr>This is an automatic backport of pull request #26 done by [Mergify](https://mergify.com).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@caleb-johnson caleb-johnson caleb-johnson approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove pydocstyle in favor of ruff
3 participants
@Eric-Arellano @coveralls @caleb-johnson