Removal of deprecated Qiskit 2.0 related code #2318
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eliarbel
suggested changes
Feb 23, 2025
| self._options_configuration = {} | ||
| self._options_properties = {} | ||
|
|
||
| def status(self): |
There was a problem hiding this comment.
Can we just remove this without a deprecation first?
| return noise_model | ||
|
|
||
| @classmethod | ||
| def from_backend_properties( |
There was a problem hiding this comment.
Same note about deprecation... I'm not sure what is the right approach for Aer.
| --- | ||
| deprecations: | ||
| - | | ||
| Remove the parts of the code that relied on deprecated `qiskit` components: |
There was a problem hiding this comment.
Suggested change
| Remove the parts of the code that relied on deprecated `qiskit` components: | |
| Remove the parts of the code that relied on deprecated `qiskit` components that are being removed in Qiskit 2.0: |
| Remove the parts of the code that relied on deprecated `qiskit` components: | ||
| * Everything that uses `convert_to_target` is removed | ||
| * Usage of `qiskit.pulse` is removed. | ||
| * Use of `BackendProperties` is removed, resulting in the removal of :class:`.NoiseModel`'s :meth:`.from_backend_properties` method. |
There was a problem hiding this comment.
BackendProperties is still mentioned in various docstrings (e.g. as a return value). Those should be cleared. It's also mentioned in Device backend noise model simulations tutorial.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Removes code that is incompatible with the upcoming Qiskit 2.0 release.
Details and comments
Qiskit 2.0 drops support for Pulse and BackendV1, resulting in several required removals:
convert_to_targetis removedqiskit.pulseis removed.BackendPropertiesis removed, resulting in the removal ofNoiseModel'sfrom_backend_propertiesmethod.BackendV1related code is removed.BackendStatuswas removed, resulting in the removal of thestatusmethod for the Aer backend.