This commit adds support for Moonraker. #160
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I copied the OctoPrint.cpp and .h and changed the API calls and getters and renamed all occurences of OctoPrintClient to MoonrakerClient. I then added two more API-call that were needed. (line 210 to 241) This one of them requires the filename property to be set first. As we’re then making a request to Moonraker with said filename as a parameter and that filename is just a file on a unix host, i needed to add urlencoding. This is a method of the MoonrakerClient class. (line 445++) I also removed trailing whitespaces and fixed indentation to two spaces in the new files. Settings.h a new comment, telling us how to enable Moonraker support. printermonitor.ino uses the new define from settings.h to enable moonraker. I also fixed the creation of Timestamps here. Signed-off-by: Robert von Könemann <[email protected]>
This was referenced Feb 18, 2022
maartenpeels
suggested changes
May 10, 2022
| WiFiClient printClient; | ||
| printClient.setTimeout(5000); | ||
|
|
||
| Serial.println("Getting Octoprint Data via GET"); |
| } | ||
| } | ||
| else { | ||
| Serial.println("Connection to OctoPrint failed: " + String(myServer) + ":" + String(myPort)); //error message if no client connect |
| WiFiClient printClient; | ||
| printClient.setTimeout(5000); | ||
|
|
||
| Serial.println("Getting Octoprint Data via POST"); |
| } | ||
| } | ||
| else { | ||
| Serial.println("Connection to OctoPrint failed: " + String(myServer) + ":" + String(myPort)); //error message if no client connect |
|
I don't suppose there are compiled binary's for the mainsail version so I can do a simple upgrade? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I copied the OctoPrint.cpp and .h and changed the API calls and getters
and renamed all occurences of OctoPrintClient to MoonrakerClient.
I then added two more API-call that were needed. (line 210 to 241)
This one of them requires the filename property to be set first.
As we’re then making a request to Moonraker with said filename as a parameter
and that filename is just a file on a unix host, i needed to add urlencoding.
This is a method of the MoonrakerClient class. (line 445++)
I also removed trailing whitespaces and fixed indentation to two spaces in the new files.
Settings.h a new comment, telling us how to enable Moonraker support.
printermonitor.ino uses the new define from settings.h to enable moonraker.
I also fixed the creation of Timestamps here.