Skip to content

Conversation

phmarti
Copy link
Member

@phmarti phmarti commented Mar 25, 2025

This PR changes the way the executable are created:

  1. It's splits the PhysicalModel, which contains the setup for nonlinear simulations, state generators and visualization generators, into three independent pieces.
  2. Removes the executables from the Framework, including the linear stability solver, shifting the reponsability to the Model.

This will require to modify all models. An example is done on Model-BoussinesqSphereRTC. Other models will be converted before merging.

@phmarti phmarti marked this pull request as draft March 25, 2025 12:20
@phmarti phmarti marked this pull request as ready for review March 25, 2025 16:31
@phmarti phmarti requested a review from castigli March 25, 2025 16:31
@phmarti phmarti changed the title Cleaninup Executables Cleaninup Executables [2.5/7] Mar 25, 2025
@phmarti phmarti changed the title Cleaninup Executables [2.5/7] Move executables to model [2.5/7] Mar 25, 2025
Base automatically changed from cleanup_stability to dev May 21, 2025 07:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant