Use environment variables instead of server.ini by default #74
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Was used to configure server.ini with environment variables.
When getting config values, try to get env variable first. If env variable doesn't exists, we keep the same workflow.
Kepler uses MYSQL_USERNAME as database username, but MariaDB container uses MYSQL_USER. So, if we use Docker with environment variables, we should use the two variables with the same values. It's a breaking change, but i won't ask MariaDB to change this variable ^^. `mysql.user` (`MYSQL_USER` for environment variable) should now be used instead of `mysql.username`
AlexandreVassard
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello !
In Quackster/Kepler#72, @emansom asked about reading environment variables instead of
server.iniby default.I'm not a Java developer at all, so i did what i can, you are free to give me some advices ! 😄
In the first place, i removed
entrypoint.sh, that was used to take env variables to configureserver.ini.After that, i have update the way that Kepler get configuration values.
Instead of just look into
server.ini, it will first look in environment variables.If a value exists in environment, it will take it, if not, we continue what we were doing with
server.ini.Note that variables keys are formated with conventionnal naming of environment variables, so uppercase with underscores.
So if we want to configure
server.portwe need to useSERVER_PORT.NOW THE BAD NEWS
One of the Kepler configuration key is
mysql.username, so with environment variables it should beMYSQL_USERNAME.The problem is, using Kepler with Docker, we also use a MariaDB container.
This MariaDB container uses
MYSQL_USER.So if we want to configure our Kepler with Docker & environment variables, we will have this in our .env file :
That's why the last commit changes all
mysql.usernametomysql.user.I would be happy to know your opinions on that.
PS : Sorry @emansom, since i'm not confortable with Java, Gradle etc... I don't really know how to use jib and stuff.