Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move command line operations to Program #13

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

PaoloOranges
Copy link

Not a bug fix or feature, a possible improvement.
I would like to separate the command line interaction from the downloader itself. In this way, GDAXDownloaderProgram.GDAXDownloader(tickers, resolution, fromDate, toDate) can be used in any other program not depending on user input or console in general.

Description

I moved input ARGS (tickers and resolution) checks to Program.cs: with tickers check on List.
I moved Console.ReadLine() to Program.cs so you can call GDAXDownloaderProgram.GDAXDownloader(tickers, resolution, fromDate, toDate) and it does not wait for the STD Input to return.

Related Issue

#12

Motivation and Context

It allows you to use GDAXDownloaderProgram.GDAXDownloader in any function/program with out depending on console IO

Requires Documentation Change

How Has This Been Tested?

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • Refactor (non-breaking change which improves implementation)
  • Performance (non-breaking change which improves performance. Please add associated performance test and results)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Non-functional change (xml comments/documentation/etc)

Checklist:

  • My code follows the code style of this project.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • My branch follows the naming convention bug-<issue#>-<description> or feature-<issue#>-<description>

# Conflicts:
#	QuantConnect.CoinbaseBrokerage.ToolBox/CoinbaseDownloaderProgram.cs
#	QuantConnect.CoinbaseBrokerage.ToolBox/Program.cs
@PaoloOranges PaoloOranges marked this pull request as ready for review February 13, 2024 22:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant