Move command line operations to Program #13
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not a bug fix or feature, a possible improvement.
I would like to separate the command line interaction from the downloader itself. In this way,
GDAXDownloaderProgram.GDAXDownloader(tickers, resolution, fromDate, toDate)
can be used in any other program not depending on user input or console in general.Description
I moved input ARGS (tickers and resolution) checks to
Program.cs
: with tickers check on List.I moved
Console.ReadLine()
toProgram.cs
so you can callGDAXDownloaderProgram.GDAXDownloader(tickers, resolution, fromDate, toDate)
and it does not wait for the STD Input to return.Related Issue
#12
Motivation and Context
It allows you to use
GDAXDownloaderProgram.GDAXDownloader
in any function/program with out depending on console IORequires Documentation Change
How Has This Been Tested?
Types of changes
Checklist:
bug-<issue#>-<description>
orfeature-<issue#>-<description>