Minor test brokerages fixes (#7552)

* AlgorithmStub Lazy Pandas Converter Set * Fix brokerages tests adding orders twice
QuantConnect · Nov 1, 2023 · 2f75c68 · 2f75c68
1 parent d2f8c73
commit 2f75c68
Show file tree

Hide file tree

Showing 3 changed files with 17 additions and 5 deletions.
diff --git a/Algorithm/QCAlgorithm.Python.cs b/Algorithm/QCAlgorithm.Python.cs
@@ -39,7 +39,7 @@ public partial class QCAlgorithm
         /// <summary>
         /// PandasConverter for this Algorithm
         /// </summary>
-        public PandasConverter PandasConverter { get; private set; }
+        public virtual PandasConverter PandasConverter { get; private set; }
 
         /// <summary>
         /// Sets pandas converter

diff --git a/Tests/Brokerages/BrokerageTests.cs b/Tests/Brokerages/BrokerageTests.cs
@@ -241,7 +241,6 @@ protected void LiquidateHoldings()
                 if (holding.Quantity == 0) continue;
                 Log.Trace("Liquidating: " + holding);
                 var order = new MarketOrder(holding.Symbol, -holding.Quantity, DateTime.UtcNow);
-                _orderProvider.Add(order);
                 PlaceOrderWaitForStatus(order, OrderStatus.Filled);
             }
         }

diff --git a/Tests/Engine/DataFeeds/AlgorithmStub.cs b/Tests/Engine/DataFeeds/AlgorithmStub.cs
@@ -32,6 +32,22 @@ public class AlgorithmStub : QCAlgorithm
         public List<SecurityChanges> SecurityChangesRecord = new List<SecurityChanges>();
         public DataManager DataManager;
         public IDataFeed DataFeed;
+
+        /// <summary>
+        /// Lanzy PandasConverter only if used
+        /// </summary>
+        public override PandasConverter PandasConverter
+        {
+            get
+            {
+                if(base.PandasConverter == null)
+                {
+                    SetPandasConverter();
+                }
+                return base.PandasConverter;
+            }
+        }
+
         public AlgorithmStub(bool createDataManager = true)
         {
             if (createDataManager)
@@ -44,8 +60,6 @@ public AlgorithmStub(bool createDataManager = true)
             var orderProcessor = new FakeOrderProcessor();
             orderProcessor.TransactionManager = Transactions;
             Transactions.SetOrderProcessor(orderProcessor);
-            PythonInitializer.Initialize();
-            SetPandasConverter();
         }
 
         public AlgorithmStub(IDataFeed dataFeed)
@@ -54,7 +68,6 @@ public AlgorithmStub(IDataFeed dataFeed)
             DataManager = new DataManagerStub(dataFeed, this);
             SubscriptionManager.SetDataManager(DataManager);
             Transactions.SetOrderProcessor(new FakeOrderProcessor());
-            SetPandasConverter();
         }
 
         public void AddSecurities(Resolution resolution = Resolution.Second, List<string> equities = null, List<string> forex = null, List<string> crypto = null)