-
Notifications
You must be signed in to change notification settings - Fork 51
Use a dialog to display the LargePortraitCard. #169
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
HaudinFlorence
wants to merge
9
commits into
QuantStack:master
Choose a base branch
from
HaudinFlorence:use_a_dialog_for_the_large_portrait_card
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Use a dialog to display the LargePortraitCard. #169
HaudinFlorence
wants to merge
9
commits into
QuantStack:master
from
HaudinFlorence:use_a_dialog_for_the_large_portrait_card
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
4a056b3
to
c56cda8
Compare
c56cda8
to
4f3d386
Compare
c269866
to
5b58c1b
Compare
dfb33bd
to
207e124
Compare
207e124
to
76faa10
Compare
26f909e
to
74ae9c6
Compare
1bcc8b2
to
3756b2d
Compare
c893c09
to
ea5a66f
Compare
ea5a66f
to
8b48f2d
Compare
8b48f2d
to
0b65a23
Compare
0b65a23
to
5f21591
Compare
5f21591
to
1f0b038
Compare
1f0b038
to
bfaeab3
Compare
bfaeab3
to
d0a34c0
Compare
… the dialog by clicking the overlay.
…es for the collaborators.
…act that the individual popup were not rendered on /about/person page when entering the corresponding url.
d0a34c0
to
b74d3a8
Compare
…ters. Add logics to not scroll systematically to the top of the page when changing from about page to portrait ones and reciprocally.
b74d3a8
to
50aab1e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use a dialog to display the LargePortraitCard.
Should fix #129