Skip to content

Allow a JupyterYModel to send and receive binary messages #23

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Allow a JupyterYModel to send and receive binary messages #23

wants to merge 1 commit into from

Conversation

davidbrochart
Copy link
Member

@davidbrochart davidbrochart added the enhancement New feature or request label May 21, 2025
trungleduc
trungleduc approved these changes May 21, 2025
View reviewed changes
src/notebookrenderer/yCommProvider.ts
}

send(message: Uint8Array) {
const messageType = new Uint8Array([2]);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

An exported constant for this magic value might be cleaner

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@trungleduc trungleduc trungleduc approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@davidbrochart @trungleduc