Added tests for map coordinates.

[borondics]

No description provided.

[markotoplak]

I am fine with this precise checking if it passes. Otherwise, it this case, where they should be mostly rounded to the integer, assertAlmostEqual with the correct parameters would be preferred.

What I do not like is that these tests only test two pixels in the first line or column (do not know which is which). The more interesting cases are the ones somewhere in the middle of the data.

[borondics]

This test file is a 4x4 map so we are actually testing the middle pixels.

[markotoplak]

Yes, you are testing middle pixels on the first row/column. Please test middle pixes on middle row/column. :)

[borondics]

How about a test like this? All the coordinates... :)

[markotoplak]

Your test was wrongly structured. map_x and map_y were not the expected outputs but their rounded-down values (your chandex x.9999 to x.0000). This was very confusing and tests should not be written like this. Instead, you should have rounded the metas to the nearest int and compared after.

I fixed this and simplified a bit.

[borondics]

Your solution is much nicer!

However, while confusing, I think the int() or round() difference is not important as what you are testing is code stability, not real things, right? In any case, thanks for the improvement.

[markotoplak]

However, while confusing, I think the int() or round() difference is not important as what you are testing is code stability, not real things, right?

Tests should always be as real as you can make them. Ideally, you write them them knowing what the output is (should not fit inputs so that the output matches). And something being confusing is definitely a maintenance problem.