Skip to content

chore: remove @qwik.dev/router dependency and fix bug when running start in ui folder #38

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 21 commits into from
May 19, 2025

Conversation

JerryWu1234
Copy link
Collaborator

1.remove @qwik.dev/router dependency and update component logic
2.fix bug when running start command in ui folder. this bug relatedhere

JerryWu1234 and others added 19 commits April 12, 2025 16:50
Add a new inspect tab to the devtools panel, allowing users to inspect the current page. This includes adding a new constant for the inspector link, updating the state type to include the inspect tab, and creating the Inspect component to render the inspect iframe.
This commit replaces the `unbuild` and `tsup` build tools with `tsdown` across the `kit` and `plugin` packages. The change simplifies the build configuration and aligns with the project's need for a more streamlined build process. The `package.json` files have been updated to reflect the new build scripts and dependencies.
Update class names to improve layout consistency and responsiveness across various components. Changes include adjusting height, width, and flex properties to ensure better visual alignment and user experience.
refactor(build): replace unbuild with tsdown for build configuration …
… logic

The @qwik.dev/router dependency was removed as it is no longer needed. Components were updated to use browser-native location properties instead of the router's useLocation hook. Additionally, useVisibleTask$ was replaced with useTask$ and isBrowser check for better compatibility and clarity.
The middleware for '/__qwik-inspect/' was unused and unnecessary, so it was removed to simplify the code and improve maintainability.
Copy link

changeset-bot bot commented May 19, 2025

⚠️ No Changeset found

Latest commit: cb2d42c

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Member

@gioboa gioboa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's great 💪

@gioboa gioboa changed the title remove @qwik.dev/router dependency and fix bug when running start in ui folder chore: remove @qwik.dev/router dependency and fix bug when running start in ui folder May 19, 2025
@gioboa gioboa merged commit 1c9b248 into QwikDev:main May 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants