improved naming of inner appSymbols

QwikDev · Feb 5, 2025 · df5c3bf · df5c3bf
1 parent 45c9752
commit df5c3bf
Show file tree

Hide file tree

Showing 2 changed files with 14 additions and 9 deletions.
diff --git a/packages/qwik-city/src/runtime/src/service-worker/setup.ts b/packages/qwik-city/src/runtime/src/service-worker/setup.ts
@@ -16,7 +16,7 @@ export const setupServiceWorkerScope = (
   linkBundles: LinkBundle[]
 ) => {
   const swFetch = swScope.fetch.bind(swScope);
-  const appSymbols = computeAppSymbols(appBundles);
+  const symbolToBundles = computeAppSymbols(appBundles);
 
   swScope.addEventListener('activate', (event) => {
     (async () => {
@@ -75,13 +75,18 @@ export const setupServiceWorkerScope = (
         }
 
         if (Array.isArray(data.symbols)) {
-          logger.log('[PREFETCHING SYMBOLS]: ', resolveSymbols(appSymbols, data.symbols));
+          logger.log(
+            '[PREFETCHING SYMBOLS]: ',
+            data.symbols,
+            ' bundles: ',
+            resolveSymbols(symbolToBundles, data.symbols)
+          );
           prefetchBundleNames(
             appBundles,
             qBuildCache,
             swFetch,
             baseUrl,
-            resolveSymbols(appSymbols, data.symbols)
+            resolveSymbols(symbolToBundles, data.symbols)
           );
         }
       }

diff --git a/packages/qwik-city/src/runtime/src/service-worker/utils.ts b/packages/qwik-city/src/runtime/src/service-worker/utils.ts
@@ -24,14 +24,14 @@ export const resolveSymbols = (appSymbols: Map<string, string>, symbolsHashes: s
   symbolsHashes.map((s) => appSymbols.get(s)).filter((s) => s != null) as string[];
 
 export const computeAppSymbols = (appBundles: AppBundle[]): AppSymbols => {
-  const appSymbols = new Map<string, string>();
+  const symbolToBundles = new Map<string, string>();
   for (const bundle of appBundles) {
-    const hashes = bundle[2];
-    if (hashes) {
-      for (const hash of hashes) {
-        appSymbols.set(hash, bundle[0]);
+    const symbols = bundle[2];
+    if (symbols) {
+      for (const symbol of symbols) {
+        symbolToBundles.set(symbol, bundle[0]);
       }
     }
   }
-  return appSymbols;
+  return symbolToBundles;
 };