Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade eslint 6115 #7143

Draft
wants to merge 28 commits into
base: main
Choose a base branch
from
Draft
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
28 commits
Select commit Hold shift + click to select a range
33904d7
feat: let eslint-plugin-qwink support Eslint 9 and 8 simultaneously
Nov 19, 2024
93f850e
feat: let eslint-plugin-qwink support Eslint 9 and 8 simultaneously
Nov 19, 2024
83909c4
Merge branch 'main' into 6048_eslint-flag
JerryWu1234 Nov 19, 2024
6953229
Merge branch 'main' into 6048_eslint-flag
JerryWu1234 Nov 22, 2024
efb017d
support 8 and 9
Nov 22, 2024
f2bdd0d
Merge branch '6048_eslint-flag' of https://github.com/JerryWu1234/qwi…
Nov 22, 2024
5c0723e
upgrade
Nov 22, 2024
0738804
upgrade
Nov 22, 2024
5ed62c5
upgrade
Nov 22, 2024
35ccf83
upgrade
Nov 22, 2024
df6f8f9
Merge branch '6048_eslint-flag' of https://github.com/JerryWu1234/qwi…
Nov 22, 2024
fc3aa53
Update qwik-binding-map.ts
JerryWu1234 Nov 22, 2024
f6d7862
upgrade
Nov 22, 2024
af55f94
upgrade
Nov 22, 2024
64b5c11
upgrade
Nov 22, 2024
cce51f0
upgrade
Nov 22, 2024
20a6fd4
upgrade
Nov 22, 2024
0bda546
upgrade
Nov 22, 2024
02cba46
fix
Nov 22, 2024
5701e52
Merge branch 'main' into 6048_eslint-flag
JerryWu1234 Nov 27, 2024
0f75492
Merge branch 'main' into 6048_eslint-flag
JerryWu1234 Nov 28, 2024
2458862
fix
Nov 28, 2024
b82a195
Merge branch '6048_eslint-flag' of https://github.com/JerryWu1234/qwi…
Nov 28, 2024
278a5df
Merge branch 'main' into 6048_eslint-flag
JerryWu1234 Nov 29, 2024
d378168
Merge branch 'main' into 6048_eslint-flag
JerryWu1234 Dec 6, 2024
0dab706
Merge branch 'main' into 6048_eslint-flag
JerryWu1234 Dec 10, 2024
1c8abcd
feat: upgrade eslint from 8 to 9
JerryWu1234 Dec 10, 2024
76eec39
Merge branch 'main' into upgrade_eslint_6115
JerryWu1234 Dec 31, 2024
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/breezy-toes-help.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'eslint-plugin-qwik': major
---

let eslint-plugin-qwik support Eslint 9 and 8 simultaneously
45 changes: 0 additions & 45 deletions .eslintrc.cjs

This file was deleted.

2 changes: 1 addition & 1 deletion e2e/qwik-cli-e2e/utils/index.ts
Original file line number Diff line number Diff line change
Expand Up @@ -67,7 +67,7 @@ function replacePackagesWithLocalOnes(tmpDir: string) {
for (const { name, absolutePath } of tarballConfig) {
patchPackageJsonForPlugin(tmpDir, name, absolutePath);
}
execSync('npm i', {
execSync('pnpm i', {
cwd: tmpDir,
// only output errors
stdio: ['ignore', 'ignore', 'inherit'],
Expand Down
47 changes: 25 additions & 22 deletions packages/insights/.eslintrc.cjs → eslint.config.mjs
Original file line number Diff line number Diff line change
@@ -1,26 +1,29 @@
module.exports = {
root: true,
env: {
browser: true,
es2021: true,
node: true,
},
extends: [
'eslint:recommended',
'plugin:@typescript-eslint/recommended',
'plugin:qwik/recommended',
],
parser: '@typescript-eslint/parser',
parserOptions: {
tsconfigRootDir: __dirname,
project: ['./tsconfig.json'],
ecmaVersion: 2021,
sourceType: 'module',
ecmaFeatures: {
jsx: true,
import eslint from '@eslint/js';
import tseslint from 'typescript-eslint';
import { fileURLToPath } from 'url';
import { dirname } from 'path';
import typescript from '@typescript-eslint/eslint-plugin';
const __dirname = dirname(fileURLToPath(import.meta.url));
import globals from 'globals';

export default tseslint.config(eslint.configs.recommended, tseslint.configs.recommended, {
languageOptions: {
parserOptions: {
sourceType: 'module',
ecmaFeatures: {
jsx: true,
},
globals: {
...globals.node,
...globals.es2021,
...globals.browser,
},
ecmaVersion: 2021,
project: ['./tsconfig.json'],
tsconfigRootDir: __dirname,
},
},
plugins: ['@typescript-eslint'],
plugins: { '@typescript-eslint': typescript },
rules: {
'@typescript-eslint/no-explicit-any': 'off',
'@typescript-eslint/explicit-module-boundary-types': 'off',
Expand All @@ -39,4 +42,4 @@ module.exports = {
'@typescript-eslint/consistent-type-imports': 'warn',
'@typescript-eslint/no-unnecessary-condition': 'warn',
},
};
});
11 changes: 6 additions & 5 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -114,7 +114,7 @@
"@types/brotli": "1.3.4",
"@types/bun": "1.1.6",
"@types/cross-spawn": "6.0.6",
"@types/eslint": "8.56.10",
"@types/eslint": "9.6.1",
"@types/express": "4.17.21",
"@types/node": "20.14.11",
"@types/path-browserify": "1.0.2",
Expand All @@ -123,8 +123,9 @@
"@types/semver": "7.5.8",
"@types/tmp": "0.2.6",
"@types/which-pm-runs": "1.0.2",
"@typescript-eslint/eslint-plugin": "7.16.1",
"@typescript-eslint/parser": "7.16.1",
"@typescript-eslint/eslint-plugin": "8.18.0",
"typescript-eslint": "8.18.0",
"globals": "15.13.0",
"all-contributors-cli": "6.26.1",
"brotli": "1.3.3",
"concurrently": "8.2.2",
Expand All @@ -133,7 +134,7 @@
"csstype": "3.1.3",
"dotenv": "16.4.5",
"esbuild": "0.20.2",
"eslint": "8.57.0",
"eslint": "9.16.0",
"eslint-plugin-no-only-tests": "3.1.0",
"eslint-plugin-qwik": "workspace:^",
"execa": "8.0.1",
Expand Down Expand Up @@ -242,10 +243,10 @@
"start": "concurrently \"npm:build.watch\" \"npm:tsc.watch\" -n build,tsc -c green,cyan",
"test": "pnpm build.full && pnpm test.unit && pnpm test.e2e",
"test.e2e": "pnpm test.e2e.chromium && pnpm test.e2e.webkit",
"test.e2e.cli": "pnpm --filter qwik-cli-e2e e2e",
"test.e2e.chromium": "playwright test starters --browser=chromium --config starters/playwright.config.ts",
"test.e2e.chromium.debug": "PWDEBUG=1 playwright test starters --browser=chromium --config starters/playwright.config.ts",
"test.e2e.city": "playwright test starters/e2e/qwikcity --browser=chromium --config starters/playwright.config.ts",
"test.e2e.cli": "pnpm --filter qwik-cli-e2e e2e",
"test.e2e.firefox": "playwright test starters --browser=firefox --config starters/playwright.config.ts",
"test.e2e.webkit": "playwright test starters --browser=webkit --config starters/playwright.config.ts",
"test.rust": "make test",
Expand Down
42 changes: 0 additions & 42 deletions packages/docs/src/routes/demo/.eslintrc.cjs

This file was deleted.

51 changes: 51 additions & 0 deletions packages/docs/src/routes/demo/eslint.config.mjs
Original file line number Diff line number Diff line change
@@ -0,0 +1,51 @@
import eslint from '@eslint/js';
import tseslint from 'typescript-eslint';
import { fileURLToPath } from 'url';
import { dirname } from 'path';
import typescript from '@typescript-eslint/eslint-plugin';
const __dirname = dirname(fileURLToPath(import.meta.url));
import globals from 'globals';

export default tseslint.config(
eslint.configs.recommended,
tseslint.configs.recommended,
{
languageOptions: {
parserOptions: {
sourceType: 'module',
ecmaFeatures: {
jsx: true,
},
globals: {
...globals.node,
...globals.es2021,
...globals.browser,
},
ecmaVersion: 2021,
project: ['./tsconfig.json'],
tsconfigRootDir: __dirname,
},
},
plugins: {
'@typescript-eslint': typescript,
},
rules: {
'@typescript-eslint/no-explicit-any': 'off',
'@typescript-eslint/explicit-module-boundary-types': 'off',
'@typescript-eslint/no-inferrable-types': 'off',
'@typescript-eslint/no-non-null-assertion': 'off',
'@typescript-eslint/no-empty-interface': 'off',
'@typescript-eslint/no-namespace': 'off',
'@typescript-eslint/no-empty-function': 'off',
'@typescript-eslint/no-this-alias': 'off',
'@typescript-eslint/ban-types': 'off',
'@typescript-eslint/ban-ts-comment': 'off',
'prefer-spread': 'off',
'no-case-declarations': 'off',
'no-console': 'off',
'@typescript-eslint/no-unused-vars': ['error'],
'@typescript-eslint/consistent-type-imports': 'warn',
'qwik/no-react-props': 'off',
},
}
);
44 changes: 0 additions & 44 deletions packages/docs/src/routes/demo/state/no-serialize/.eslintrc.cjs

This file was deleted.

Original file line number Diff line number Diff line change
@@ -0,0 +1,54 @@
import eslint from '@eslint/js';
import tseslint from 'typescript-eslint';
import { fileURLToPath } from 'url';
import { dirname } from 'path';
import typescript from '@typescript-eslint/eslint-plugin';
import qwik from 'eslint-plugin-qwik';
const __dirname = dirname(fileURLToPath(import.meta.url));
import globals from 'globals';

export default tseslint.config(
eslint.configs.recommended,
tseslint.configs.recommended,
qwik.configs.recommended,
{
languageOptions: {
parserOptions: {
sourceType: 'module',
ecmaFeatures: {
jsx: true,
},
globals: {
...globals.node,
...globals.es2021,
...globals.browser,
},
ecmaVersion: 2021,
project: ['../../tsconfig.json'],
tsconfigRootDir: __dirname,
},
},
plugins: {
'@typescript-eslint': typescript,
},
rules: {
'@typescript-eslint/no-explicit-any': 'off',
'@typescript-eslint/explicit-module-boundary-types': 'off',
'@typescript-eslint/no-inferrable-types': 'off',
'@typescript-eslint/no-non-null-assertion': 'off',
'@typescript-eslint/no-empty-interface': 'off',
'@typescript-eslint/no-namespace': 'off',
'@typescript-eslint/no-empty-function': 'off',
'@typescript-eslint/no-this-alias': 'off',
'@typescript-eslint/ban-types': 'off',
'@typescript-eslint/ban-ts-comment': 'off',
'prefer-spread': 'off',
'no-case-declarations': 'off',
'no-console': 'off',
'@typescript-eslint/no-unused-vars': ['error'],
'@typescript-eslint/consistent-type-imports': 'warn',
'qwik/no-react-props': 'off',
'qwik/valid-lexical-scope': 'off',
},
}
);
Loading
Loading