Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(core): schedule QRLs instead of direct execution #7269

Merged
merged 19 commits into from
Feb 6, 2025
Merged

Conversation

wmertens
Copy link
Member

@wmertens wmertens commented Jan 19, 2025

This makes it possible to call functions from core in QRLs, and uses it to schedule event handlers properly.

This removes the haphazard _hW exports from segments and replaces them with a single core export _task.

This is cleaner and allows core to provide qrl functions.

@wmertens wmertens requested a review from a team as a code owner January 19, 2025 11:59
Copy link

pkg-pr-new bot commented Jan 19, 2025

Open in Stackblitz

npm i https://pkg.pr.new/QwikDev/qwik/@qwik.dev/core@7269
npm i https://pkg.pr.new/QwikDev/qwik/@qwik.dev/router@7269
npm i https://pkg.pr.new/QwikDev/qwik/eslint-plugin-qwik@7269
npm i https://pkg.pr.new/QwikDev/qwik/create-qwik@7269

commit: 2d8dc0b

Copy link

changeset-bot bot commented Jan 19, 2025

🦋 Changeset detected

Latest commit: 2d8dc0b

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 5 packages
Name Type
@qwik.dev/core Patch
eslint-plugin-qwik Patch
@qwik.dev/react Patch
@qwik.dev/router Patch
create-qwik Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

github-actions bot commented Jan 19, 2025

built with Refined Cloudflare Pages Action

⚡ Cloudflare Pages Deployment

Name Status Preview Last Commit
qwik-docs ✅ Ready (View Log) Visit Preview 2d8dc0b

@wmertens wmertens changed the title refactor(core): use a core export for task qrls refactor(core): schedule QRLs instead of direct execution Jan 19, 2025
@wmertens wmertens force-pushed the remove-hW branch 3 times, most recently from 35a5079 to 75710de Compare January 20, 2025 15:17
packages/qwik/src/core/client/queue-qrl.ts Outdated Show resolved Hide resolved
packages/qwik/src/core/shared/scheduler.ts Outdated Show resolved Hide resolved
packages/qwik/src/optimizer/src/manifest.ts Show resolved Hide resolved
@wmertens wmertens force-pushed the remove-hW branch 4 times, most recently from bddac05 to ec7e9b2 Compare January 22, 2025 15:25
@Varixo Varixo requested review from a team as code owners January 25, 2025 18:17
@wmertens wmertens force-pushed the remove-hW branch 4 times, most recently from 743383c to 22fd83b Compare January 30, 2025 13:48
@Varixo Varixo force-pushed the remove-hW branch 3 times, most recently from 75fa025 to a688c83 Compare February 2, 2025 21:35
@wmertens wmertens merged commit 7c21496 into build/v2 Feb 6, 2025
22 checks passed
@wmertens wmertens deleted the remove-hW branch February 6, 2025 15:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants